Re: [PATCH] locking/atomics: don't alias ____ptr

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] locking/atomics: don't alias ____ptr
Date	2017-06-28 20:30 +0200
Message-ID	<tXpSW-V2-7@gated-at.bofh.it> (permalink)
References	(6 earlier) <tXlcC-7iY-15@gated-at.bofh.it> <tXlFF-7uy-31@gated-at.bofh.it> <tXlYZ-7Qx-3@gated-at.bofh.it> <tXn4K-6m-17@gated-at.bofh.it> <tXnxO-hR-61@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 28 Jun 2017, Mark Rutland wrote:
> On Wed, Jun 28, 2017 at 05:24:24PM +0200, Thomas Gleixner wrote:
> Given we're gonig to clean things up, we may as well avoid the backwards
> include of <asm-generic/atomic_instrumented.h>, whcih was only there as
> a bodge:
> 
> For the UP arches we do:
> # echo '#include <asm-generic/atomic_up.h>' >arch/xxx/include/asm/atomic.h
> # mv include/asm-generic/atomic.h include/asm-generic/atomic_up.h
> 
> Then we add a <linux/atomic_instrumented.h>:
> 
> #ifndef __LINUX_ATOMIC_INSTRUMENTED_H
> #define __LINUX_ATOMIC INSTRUMENTED_H
> 
> #include <asm/atomic.h>
> 
> #if CONFIG_ATOMIC_INSTRUMENTED_H
> <instrumentation>
> #endif
> 
> #endif /* __LINUX_ATOMIC_ARCH_H */
> 
> ... and make <linux/atomic.h> incldue that rather than <asm/atomic.h>.
> 
> That way the instrumentation's orthogonal to the UP-ness of the arch,
> and we can fold any other instrumentation in there, or later move it
> directly into <linux/atomic.h>

Sounds like a plan.

Thanks,

	tglx

Thread

[PATCH v5 3/4] asm-generic: add KASAN instrumentation to atomic operations Dmitry Vyukov <dvyukov@google.com> - 2017-06-22 16:20 +0200
  [tip:locking/core] locking/atomics, asm-generic: Add KASAN  instrumentation to atomic operations tip-bot for Dmitry Vyukov <tipbot@zytor.com> - 2017-06-23 16:10 +0200
  [PATCH] locking/atomics: don't alias ____ptr Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2017-06-28 12:10 +0200
    Re: [PATCH] locking/atomics: don't alias ____ptr Dmitry Vyukov <dvyukov@google.com> - 2017-06-28 12:20 +0200
      Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 13:20 +0200
        Re: [PATCH] locking/atomics: don't alias ____ptr Dmitry Vyukov <dvyukov@google.com> - 2017-06-28 13:20 +0200
          Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 13:30 +0200
            Re: [PATCH] locking/atomics: don't alias ____ptr Mark Rutland <mark.rutland@arm.com> - 2017-06-28 14:50 +0200
          Re: [PATCH] locking/atomics: don't alias ____ptr Dmitry Vyukov <dvyukov@google.com> - 2017-06-28 14:30 +0200
            Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 15:40 +0200
          Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 14:30 +0200
      Re: [PATCH] locking/atomics: don't alias ____ptr Sebastian Andrzej Siewior <bigeasy@linutronix.de> - 2017-06-28 14:20 +0200
        Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 15:30 +0200
          Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 16:00 +0200
            Re: [PATCH] locking/atomics: don't alias ____ptr Mark Rutland <mark.rutland@arm.com> - 2017-06-28 16:20 +0200
              Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 17:30 +0200
                Re: [PATCH] locking/atomics: don't alias ____ptr Mark Rutland <mark.rutland@arm.com> - 2017-06-28 18:00 +0200
                Re: [PATCH] locking/atomics: don't alias ____ptr Ingo Molnar <mingo@kernel.org> - 2017-06-28 20:00 +0200
                Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-28 20:30 +0200
                Re: [PATCH] locking/atomics: don't alias ____ptr Thomas Gleixner <tglx@linutronix.de> - 2017-06-29 08:50 +0200

csiph-web