Re: [PATCH V4 07/12] cgroup: export fhandle info for a cgroup

Path	csiph.com!news.mixmin.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Tejun Heo <tj@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 07/12] cgroup: export fhandle info for a cgroup
Date	Wed, 28 Jun 2017 20:20:03 +0200
Message-ID	<tXpJh-Rv-31@gated-at.bofh.it> (permalink)
References	<tXppV-t5-19@gated-at.bofh.it> <tXpq2-t5-161@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=HEFoG2qWBHbA5Q+DNp13xIN+gpQ4do4zk64bAc8TGz8=; b=P200ks7hWR+19uKCPkIQ//MGf6YvE36na+U1gvKYFarhtWL1ajqQa8C7u/bsxkJnQo uwx5QfVnZeI22hIGEQvrIlvpddznxt4t9PPueCrBjDJq+hkFpbFqpl480C+j3kOex9xy Er7tPKdUvDWJJGVwFi7VqT3yzY1M0x0XaTL8JVBul2S2e9zSTqZXz3N/nyI+64bHIlih RilMEtGQRISdqEBMnuBFX4VzRUnpKF/6dwcTvd9pYDUeuTdgzJe/1UvZeAV+Ih6ea06n 1Wa3OjsuBryoEL323Z1Mp9W45X+OOXbWg0hkBFIDxrqLZDKds4yZs1A9FZ/+mpv2xWJ1 krVw==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=HEFoG2qWBHbA5Q+DNp13xIN+gpQ4do4zk64bAc8TGz8=; b=I4cWo4vgIv55RoMRj8kAfNP36RZHJ0gazbh3fism2R+gkrp5FAlPfUJzt9lsygm449 XM9D4RQ0rAMNsFtZ5AbHW2MY1hNeBnoEAVIYcVMqVyhx2TQQkmTx3OtXPSue3iTpvSG+ ShfLAyLXzOyNS1Sl5D5G6UyHvWRH8P5sWcdAlFw3jhCfXQJmsabt+g5jcxKL77W23toU jqFDqZfIx0T3f3b2JZbv3wp1mRHHV9JZeM/wOJboARITpCcPmxggH/+YSthefOsceaL1 OXOol4bcjsoXSlyM836or+CYwix2lhhAlumwMhYQZvGprqMgrGj/ic73jrQR+MYOUio6 R2hw==
X-Gm-Message-State	AKS2vOy1TjYZcaA21L9ELkXhGxx65g7ibCe5MpLX8JH2d2QI1fnQEmFz sW2og0SNabeb6A==
X-Received	by 10.37.203.74 with SMTP id b71mr9145433ybg.209.1498673578456; Wed, 28 Jun 2017 11:12:58 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.8.3 (2017-05-23)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, gregkh@linuxfoundation.org, hch@lst.de, axboe@fb.com, rostedt@goodmis.org, lizefan@huawei.com, Kernel-team@fb.com, Shaohua Li <shli@fb.com>
X-Original-Date	Wed, 28 Jun 2017 14:12:56 -0400
X-Original-Message-ID	<20170628181256.GC24647@htj.duckdns.org>
X-Original-References	<cover.1498666964.git.shli@fb.com> <a81d74a4e19be95207d7455ec9abb4fb0b4d1736.1498666964.git.shli@fb.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1677038

Show key headers only | View raw

On Wed, Jun 28, 2017 at 09:29:57AM -0700, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
> 
> Add an API to export cgroup fhandle info. We don't export a full 'struct
> file_handle', there are unrequired info. Sepcifically, cgroup is always
> a directory, so we don't need a 'FILEID_INO32_GEN_PARENT' type fhandle,
> we only need export the inode number and generation number just like
> what generic_fh_to_dentry does. And we can avoid the overhead of getting
> an inode too, since kernfs_node_id (ino and generation) has all the info
> required.
> 
> Signed-off-by: Shaohua Li <shli@fb.com>

Acked-by: Tejun Heo <tj@kernel.org>

Thanks.

-- 
tejun

Thread

[PATCH V4 00/12] blktrace: output cgroup info Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
  [PATCH V4 09/12] block: always attach cgroup info into bio Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
  [PATCH V4 07/12] cgroup: export fhandle info for a cgroup Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
    Re: [PATCH V4 07/12] cgroup: export fhandle info for a cgroup Tejun Heo <tj@kernel.org> - 2017-06-28 20:20 +0200
  [PATCH V4 06/12] kernfs: add exportfs operations Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
    Re: [PATCH V4 06/12] kernfs: add exportfs operations Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 15:00 +0200
  Re: [PATCH V4 00/12] blktrace: output cgroup info Jens Axboe <axboe@kernel.dk> - 2017-06-28 20:00 +0200
  [PATCH V4 10/12] block: call __bio_free in bio_endio Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
    Re: [PATCH V4 10/12] block: call __bio_free in bio_endio Christoph Hellwig <hch@lst.de> - 2017-06-28 23:30 +0200
      Re: [PATCH V4 10/12] block: call __bio_free in bio_endio Shaohua Li <shli@kernel.org> - 2017-06-28 23:50 +0200
        Re: [PATCH V4 10/12] block: call __bio_free in bio_endio Christoph Hellwig <hch@lst.de> - 2017-06-29 19:20 +0200
          Re: [PATCH V4 10/12] block: call __bio_free in bio_endio Shaohua Li <shli@kernel.org> - 2017-06-29 20:40 +0200
            Re: [PATCH V4 10/12] block: call __bio_free in bio_endio Christoph Hellwig <hch@lst.de> - 2017-06-29 22:30 +0200
  [PATCH V4 11/12] blktrace: add an option to allow displying cgroup path Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
  [PATCH V4 08/12] blktrace: export cgroup info in trace Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
  [PATCH V4 02/12] kernfs: implement i_generation Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
    Re: [PATCH V4 02/12] kernfs: implement i_generation Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 15:00 +0200
  [PATCH V4 05/12] kernfs: introduce kernfs_node_id Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
    Re: [PATCH V4 05/12] kernfs: introduce kernfs_node_id Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 15:00 +0200

csiph-web