Re: [PATCH 1/3] iommu: Return ERR_PTR() values from device_group call-backs

From	Gerald Schaefer <gerald.schaefer@de.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] iommu: Return ERR_PTR() values from device_group call-backs
Date	2017-06-28 17:50 +0200
Message-ID	<tXno7-dY-33@gated-at.bofh.it> (permalink)
References	<tXjXc-6DX-5@gated-at.bofh.it>
Organization	IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz / Geschaeftsfuehrung: Dirk Wittkopp / Sitz der Gesellschaft: Boeblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294

Show all headers | View raw

On Wed, 28 Jun 2017 14:00:56 +0200
Joerg Roedel <joro@8bytes.org> wrote:

> From: Joerg Roedel <jroedel@suse.de>
> 
> The generic device_group call-backs in iommu.c return NULL
> in case of error. Since they are getting ERR_PTR values from
> iommu_group_alloc(), just pass them up instead.
> 
> Reported-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>
> Signed-off-by: Joerg Roedel <jroedel@suse.de>
> ---

Looks good,
Reviewed-by: Gerald Schaefer <gerald.schaefer@de.ibm.com>


>  drivers/iommu/iommu.c | 14 ++------------
>  1 file changed, 2 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index cf7ca7e..de09e1e 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -915,13 +915,7 @@ static int get_pci_alias_or_group(struct pci_dev *pdev, u16 alias, void *opaque)
>   */
>  struct iommu_group *generic_device_group(struct device *dev)
>  {
> -	struct iommu_group *group;
> -
> -	group = iommu_group_alloc();
> -	if (IS_ERR(group))
> -		return NULL;
> -
> -	return group;
> +	return iommu_group_alloc();
>  }
> 
>  /*
> @@ -988,11 +982,7 @@ struct iommu_group *pci_device_group(struct device *dev)
>  		return group;
> 
>  	/* No shared group found, allocate new */
> -	group = iommu_group_alloc();
> -	if (IS_ERR(group))
> -		return NULL;
> -
> -	return group;
> +	return iommu_group_alloc();
>  }
> 
>  /**

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] iommu: Return ERR_PTR() values from device_group call-backs Joerg Roedel <joro@8bytes.org> - 2017-06-28 14:10 +0200
  [PATCH 2/3] iommu/omap: Return ERR_PTR in device_group call-back Joerg Roedel <joro@8bytes.org> - 2017-06-28 14:10 +0200
    Re: [PATCH 2/3] iommu/omap: Return ERR_PTR in device_group call-back Suman Anna <s-anna@ti.com> - 2017-06-28 20:00 +0200
  Re: [PATCH 1/3] iommu: Return ERR_PTR() values from device_group  call-backs Gerald Schaefer <gerald.schaefer@de.ibm.com> - 2017-06-28 17:50 +0200

csiph-web