Re: [PATCH v3 4/4] misc: sram: Allow ARM64 to select SRAM_EXEC

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 4/4] misc: sram: Allow ARM64 to select SRAM_EXEC
Date	2017-06-28 17:10 +0200
Message-ID	<tXmLn-8q5-1@gated-at.bofh.it> (permalink)
References	<tT9tn-7uo-3@gated-at.bofh.it> <tT9to-7uo-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 16, 2017 at 05:07:44PM -0700, Florian Fainelli wrote:
> Now that ARM64 also has a fncpy() implementation, allow selection
> SRAM_EXEC for ARM64 as well.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
>  drivers/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 07bbd4cc1852..ac8779278c0c 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -464,7 +464,7 @@ config SRAM
>  	bool "Generic on-chip SRAM driver"
>  	depends on HAS_IOMEM
>  	select GENERIC_ALLOCATOR
> -	select SRAM_EXEC if ARM
> +	select SRAM_EXEC if ARM || ARM64
>  	help
>  	  This driver allows you to declare a memory region to be managed by
>  	  the genalloc API. It is supposed to be used for small on-chip SRAM

As stated in another thread [1], NAK to this patch.

Currently there are no users of this interface that we wish to enable
for arm64, and this is liable to be abused to add platform-specific
stuff that we expect to live in PSCI or other secure FW.

Until we have a user that does not fall into that bucket, I see no
reason to enable this for arm64.

Thanks,
Mark.

[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-June/516161.html

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v3 4/4] misc: sram: Allow ARM64 to select SRAM_EXEC Mark Rutland <mark.rutland@arm.com> - 2017-06-28 17:10 +0200

csiph-web