Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676762

Re: [PATCH] clk: scpi: error when clock fails to register

Show all headers | View raw

On 28/06/17 14:53, Jerome Brunet wrote:
> Current implementation of scpi_clk_add just print a warning when clock
> fails to register but then keep going as if nothing happened. The
> provider is then registered with bogus data.
> 
> This may latter lead to an Oops in __clk_create_clk when
> hlist_add_head(&clk->clks_node, &hw->core->clks) is called.
> 

What's the path of this call ? I see one in devm_clk_hw_register
but that's one which failed.

Also one of the reason for keeping it continuing is, if firmware fails
on some non-critical clock, that's fine rather than punishing the entire
set of clocks and may even fail the boot.

-- 
Regards,
Sudeep

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clk: scpi: error when clock fails to register Jerome Brunet <jbrunet@baylibre.com> - 2017-06-28 16:00 +0200
  Re: [PATCH] clk: scpi: error when clock fails to register Sudeep Holla <sudeep.holla@arm.com> - 2017-06-28 17:10 +0200
    Re: [PATCH] clk: scpi: error when clock fails to register Jerome Brunet <jbrunet@baylibre.com> - 2017-06-28 17:40 +0200
      Re: [PATCH] clk: scpi: error when clock fails to register Sudeep Holla <sudeep.holla@arm.com> - 2017-06-28 18:00 +0200
        Re: [PATCH] clk: scpi: error when clock fails to register Sudeep Holla <sudeep.holla@arm.com> - 2017-06-28 20:00 +0200
          Re: [PATCH] clk: scpi: error when clock fails to register Stephen Boyd <sboyd@codeaurora.org> - 2017-06-29 00:40 +0200
          Re: [PATCH] clk: scpi: error when clock fails to register Jerome Brunet <jbrunet@baylibre.com> - 2017-06-29 11:00 +0200
            Re: [PATCH] clk: scpi: error when clock fails to register Sudeep Holla <sudeep.holla@arm.com> - 2017-06-29 11:20 +0200
        Re: [PATCH] clk: scpi: error when clock fails to register Jerome Brunet <jbrunet@baylibre.com> - 2017-06-28 20:00 +0200
  Re: [PATCH] clk: scpi: error when clock fails to register Sudeep Holla <sudeep.holla@arm.com> - 2017-06-29 11:10 +0200
  Re: [PATCH] clk: scpi: error when clock fails to register Stephen Boyd <sboyd@codeaurora.org> - 2017-06-30 02:30 +0200

csiph-web