Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1676635
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] staging: rts5208 : Fixing coding style warnings |
| Date | 2017-06-28 15:00 +0200 |
| Message-ID | <tXkJz-6TW-5@gated-at.bofh.it> (permalink) |
| References | <tXjXc-6DX-25@gated-at.bofh.it> <tXkJz-6TW-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, Jun 28, 2017 at 02:50:12PM +0200, Simo Koskinen wrote:
> Fixed following warnings found by checkpatch.pl script:
>
> WARNING: Prefer using '"%s...", __func__' to using 'xxxx',
> this function's name, in a string
>
> Signed-off-by: Simo Koskinen <koskisoft@gmail.com>
Is this different from a previous patch? If so, you need to properly
version your patch, as the documentation descripts how to do.
> ---
> drivers/staging/rts5208/rtsx.c | 2 --
> drivers/staging/rts5208/rtsx_chip.c | 4 ++--
> drivers/staging/rts5208/sd.c | 8 ++++----
> drivers/staging/rts5208/spi.c | 8 ++++----
> drivers/staging/rts5208/xd.c | 11 ++++++-----
> 5 files changed, 16 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index b8177f5..c7ae702 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -1009,8 +1009,6 @@ static void rtsx_remove(struct pci_dev *pci)
> {
> struct rtsx_dev *dev = pci_get_drvdata(pci);
>
> - dev_info(&pci->dev, "rtsx_remove() called\n");
> -
This change does not match up with the changelog text :(
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] staging: rts5208 : Fixing coding style warnings Simo Koskinen <koskisoft@gmail.com> - 2017-06-28 11:20 +0200
Re: [PATCH] staging: rts5208 : Fixing coding style warnings Greg KH <gregkh@linuxfoundation.org> - 2017-06-28 14:10 +0200
Re: [PATCH] staging: rts5208 : Fixing coding style warnings Greg KH <gregkh@linuxfoundation.org> - 2017-06-28 15:00 +0200
Re: [PATCH] staging: rts5208 : Fixing coding style warnings Frans Klaver <fransklaver@gmail.com> - 2017-06-28 15:00 +0200
[PATCH] staging: rts5208 : Fixing coding style warnings Simo Koskinen <koskisoft@gmail.com> - 2017-06-28 15:00 +0200
csiph-web