Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676515

Re: [PATCH 5/9] iommu: Introduce fault notifier API

Show all headers | View raw

On Tue, Jun 27, 2017 at 12:47:59PM -0700, Jacob Pan wrote:
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index d973555..07cfd92 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -48,6 +48,7 @@ struct iommu_group {
>  	struct list_head devices;
>  	struct mutex mutex;
>  	struct blocking_notifier_head notifier;
> +	struct blocking_notifier_head fault_notifier;

Do you really need a notifier chain here? Will there ever be more than
one callback registered to it?

> +struct iommu_fault_event {
> +	struct device *dev;

Putting a 'struct device *' member in a uapi struct looks fundamentally
wrong.



	Joerg

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 0/9] IOMMU driver support for shared virtual memory virtualization Jacob Pan <jacob.jun.pan@linux.intel.com> - 2017-06-27 21:50 +0200
  [PATCH 6/9] iommu/vt-d: track device with pasid table bond to a guest Jacob Pan <jacob.jun.pan@linux.intel.com> - 2017-06-27 21:50 +0200
  [PATCH 7/9] iommu/dmar: notify unrecoverable faults Jacob Pan <jacob.jun.pan@linux.intel.com> - 2017-06-27 21:50 +0200
  [PATCH 8/9] iommu/intel-svm: notify page request to guest Jacob Pan <jacob.jun.pan@linux.intel.com> - 2017-06-27 21:50 +0200
  [PATCH 5/9] iommu: Introduce fault notifier API Jacob Pan <jacob.jun.pan@linux.intel.com> - 2017-06-27 21:50 +0200
    Re: [PATCH 5/9] iommu: Introduce fault notifier API Joerg Roedel <joro@8bytes.org> - 2017-06-28 12:20 +0200
      Re: [PATCH 5/9] iommu: Introduce fault notifier API Jacob Pan <jacob.jun.pan@linux.intel.com> - 2017-06-28 20:00 +0200

csiph-web