[PATCH] drivers: perf: hisi: fix ptr_ret.cocci warnings

Path	csiph.com!weretis.net!feeder6.news.weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	kbuild test robot <lkp@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH] drivers: perf: hisi: fix ptr_ret.cocci warnings
Date	Wed, 28 Jun 2017 12:50:02 +0200
Message-ID	<tXiHM-5FO-7@gated-at.bofh.it> (permalink)
References	<tXiHL-5FO-1@gated-at.bofh.it> <tWTzJ-5PY-29@gated-at.bofh.it>
X-Original-To	Shaokun Zhang <zhangshaokun@hisilicon.com>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.40,275,1496127600"; d="scan'208";a="102261705"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	<locally generated>
X-Sa-Exim-Mail-From	fengguang.wu@intel.com
X-Sa-Exim-Scanned	No (on bee); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	29
Organization	linux.* mail to news gateway
X-Original-Cc	kbuild-all@01.org, mark.rutland@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linuxarm@huawei.com, Shaokun Zhang <zhangshaokun@hisilicon.com>, Anurup M <anurup.m@huawei.com>
X-Original-Date	Wed, 28 Jun 2017 18:42:18 +0800
X-Original-Message-ID	<20170628104218.GA32735@lkp-wsm-ep1>
X-Original-References	<201706281831.GsZKCdMT%fengguang.wu@intel.com> <1498552001-182148-6-git-send-email-zhangshaokun@hisilicon.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1676547

Show key headers only | View raw

drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c:274:1-3: WARNING: PTR_ERR_OR_ZERO can be used


 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 2dd3bcc1c8a7 ("drivers: perf: hisi: Add support for HiSilicon SoC DDRC PMU driver")
CC: Shaokun Zhang <zhangshaokun@hisilicon.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

 hisi_uncore_ddrc_pmu.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

--- a/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
+++ b/drivers/perf/hisilicon/hisi_uncore_ddrc_pmu.c
@@ -271,10 +271,7 @@ static int hisi_ddrc_pmu_init_data(struc
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	ddrc_pmu->base = devm_ioremap_resource(dev, res);
-	if (IS_ERR(ddrc_pmu->base))
-		return PTR_ERR(ddrc_pmu->base);
-
-	return 0;
+	return PTR_ERR_OR_ZERO(ddrc_pmu->base);
 }
 
 static struct attribute *hisi_ddrc_pmu_format_attr[] = {

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 5/6] drivers: perf: hisi: Add support for HiSilicon SoC DDRC PMU driver Shaokun Zhang <zhangshaokun@hisilicon.com> - 2017-06-27 10:00 +0200
  Re: [PATCH 5/6] drivers: perf: hisi: Add support for HiSilicon SoC  DDRC PMU driver kbuild test robot <lkp@intel.com> - 2017-06-28 12:50 +0200
  [PATCH] drivers: perf: hisi: fix ptr_ret.cocci warnings kbuild test robot <lkp@intel.com> - 2017-06-28 12:50 +0200

csiph-web