Re: [PATCH 1/9] iommu: Introduce bind_pasid_table API function

From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/9] iommu: Introduce bind_pasid_table API function
Date	2017-06-28 12:00 +0200
Message-ID	<tXhVo-5as-9@gated-at.bofh.it> (permalink)
References	<tX4EN-57v-3@gated-at.bofh.it> <tX4EO-57v-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Jun 27, 2017 at 12:47:55PM -0700, Jacob Pan wrote:
> +int iommu_bind_pasid_table(struct iommu_domain *domain, struct device *dev,
> +			struct pasid_table_info *pasidt_binfo)
> +{
> +	if (unlikely(!domain->ops->bind_pasid_table))
> +		return -EINVAL;

I think its better to return -ENODEV here, like other iommu-api
functions do when a callback is NULL.

> +enum iommu_model {
> +	IOMMU_MODEL_INTEL_VTD,
> +	IOMMU_MODEL_ARM_SMMU,
> +};

AMD IOMMU also supports shared virtual memory.

Regards,

	Joerg

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/9] iommu: Introduce bind_pasid_table API function Jacob Pan <jacob.jun.pan@linux.intel.com> - 2017-06-27 21:50 +0200
  Re: [PATCH 1/9] iommu: Introduce bind_pasid_table API function Joerg Roedel <joro@8bytes.org> - 2017-06-28 12:00 +0200

csiph-web