Re: [PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Benjamin Gaignard <benjamin.gaignard@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU
Date	Wed, 28 Jun 2017 09:40:02 +0200
Message-ID	<tXfJU-3SL-9@gated-at.bofh.it> (permalink)
References	<tWylA-tB-21@gated-at.bofh.it> <tX0Bc-2nz-31@gated-at.bofh.it> <tX20h-3fI-15@gated-at.bofh.it> <tX2D0-3Ko-25@gated-at.bofh.it>
X-Original-To	Christoph Hellwig <hch@lst.de>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+wfAIaUHVU/nKboljst04rt7Zp0pGHDOhWekyw+nj0k=; b=Qw6ierJ4Iq4silu/ILIKxcVWnnbbbRVTXgIeHBFRxLxlxk1s4e7ipoFogRJKcEZ1dK h015m7EjP55oGD45tLrHyABmWU/HF/8wUvhtHVGZuCB/smt6zV3SAO9RtYPh5L0IFx1B QhizB2EntvezJLNFiapMvTXG8t2XIaCkig2W4=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+wfAIaUHVU/nKboljst04rt7Zp0pGHDOhWekyw+nj0k=; b=KJbCIliFkgoE27UcylHpEi1ecW1x4dNc4BrC499fc8iU2f/wWd3T6vAKzcdkJJIMNu pj2KEAMgzLGdd0ekzPxrlYYty8QFFbhaRA4gjKZhp2Q9ZSlwtnlm2gNbZtzVEkbyVa3I MzwPf9U2rOaEujrEtrzvGFx5VrHrJTXnSihTitVOb1vwf3AC0G0cumjPlXzmP+GHUZBY vo3leYvCucXc1tNR/BG5dXzVn14EBVte9djVM3OPSa65qmX06K8aGnVtZ4iTiCMsMPp4 Z6GIE4TEm/V5U1+x51vLvxtSsMbAqoY3WgDmwf7vENS7wkCgqzjNtFKha/YxpzvFCQAF WuYw==
X-Gm-Message-State	AKS2vOyNPmR7WrrR4R/t1Q/UR81BDNV5bmBJ1wmlUgkJ8Eqsg6rNh4EE NFkqtsQwoe3AFihRYzHDqy7kCtAaOz8a
X-Received	by 10.200.42.187 with SMTP id b56mr11004669qta.122.1498635214399; Wed, 28 Jun 2017 00:33:34 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset="UTF-8"
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	24
Organization	linux.* mail to news gateway
X-Original-Cc	Russell King - ARM Linux <linux@armlinux.org.uk>, Vladimir Murzin <vladimir.murzin@arm.com>, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Szemző András <sza@esh.hu>, Arnd Bergmann <arnd@arndb.de>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Andrew Morton <akpm@linux-foundation.org>, Alexandre Torgue <alexandre.torgue@st.com>, robin.murphy@arm.com, kbuild-all@01.org, Marek Szyprowski <m.szyprowski@samsung.com>, Joerg Roedel <jroedel@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Michal Nazarewicz <mina86@mina86.com>, Alan Stern <stern@rowland.harvard.edu>, Yoshinori Sato <ysato@users.sourceforge.jp>, Rich Felker <dalias@libc.org>, Roger Quadros <rogerq@ti.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Doug Ledford <dledford@redhat.com>
X-Original-Date	Wed, 28 Jun 2017 09:33:33 +0200
X-Original-Message-ID	<CA+M3ks6zBzh6oZ-LoVoFEu81vEeH_q=bhWnGrYAgDSpB+kfxyQ@mail.gmail.com>
X-Original-References	<1498468741-12020-1-git-send-email-vladimir.murzin@arm.com> <20170627152753.GA29186@lst.de> <20170627165416.GP4902@n2100.armlinux.org.uk> <20170627173640.GA375@lst.de>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1676425

Show key headers only | View raw

2017-06-27 19:36 GMT+02:00 Christoph Hellwig <hch@lst.de>:
> On Tue, Jun 27, 2017 at 05:54:17PM +0100, Russell King - ARM Linux wrote:
>> On Tue, Jun 27, 2017 at 05:27:53PM +0200, Christoph Hellwig wrote:
>> > I've applied patches 1, 3 and 4 to the dma-mapping tree.  2 will need
>> > a respin for less code duplication.  I'd be happy to take 5,6 and 7 if
>> > Russell is fine with that.
>>
>> If Vladimir is okay with those going in without patch 2, then I'm
>> happy - I seem to remember a mail from Vladimir stating that they
>> depended on some of the previous patches, but I don't know which.
>>
>> Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Thanks, I'll add them.  Patch 2 only adds optional mmap functionality,
> so it's not really required.  Although I'd really like to see a fixed
> up version that I can merge anyway.

Without mmap we will have a regression for nommu platform which are using
dma_alloc_coherent and specialy in drm/kms where dumb buffer are allocated
like that.
Even with this problem I think the patches should be merged but we should have
a quick fix for mmap.

Benjamin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:20 +0200
  [PATCH v6 1/7] dma: Take into account dma_pfn_offset Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:30 +0200
  [PATCH v6 4/7] drivers: dma-coherent: Introduce default DMA pool Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:30 +0200
  [PATCH v6 5/7] ARM: NOMMU: Introduce dma operations for noMMU Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:30 +0200
  [PATCH v6 2/7] dma: Add simple dma_noop_mmap Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:30 +0200
  [PATCH v6 3/7] drivers: dma-coherent: Account dma_pfn_offset when used with device tree Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:30 +0200
  [PATCH v6 7/7] ARM: dma-mapping: Remove traces of NOMMU code Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:30 +0200
  [PATCH v6 6/7] ARM: NOMMU: Set ARM_DMA_MEM_BUFFERABLE for M-class cpus Vladimir Murzin <vladimir.murzin@arm.com> - 2017-06-26 11:30 +0200
  Re: [PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for         NOMMU Christoph Hellwig <hch@lst.de> - 2017-06-26 12:40 +0200
  Re: [PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for         NOMMU Christoph Hellwig <hch@lst.de> - 2017-06-27 17:30 +0200
    Re: [PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for  NOMMU Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-27 19:00 +0200
      Re: [PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for         NOMMU Christoph Hellwig <hch@lst.de> - 2017-06-27 19:40 +0200
        Re: [PATCH v6 0/7] ARM: Fix dma_alloc_coherent() and friends for NOMMU Benjamin Gaignard <benjamin.gaignard@linaro.org> - 2017-06-28 09:40 +0200

csiph-web