Re: [PATCH 2/6] drivers: perf: hisi: Add support for HiSilicon SoC uncore PMU driver

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod
From	Zhangshaokun <zhangshaokun@hisilicon.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/6] drivers: perf: hisi: Add support for HiSilicon SoC uncore PMU driver
Date	Wed, 28 Jun 2017 08:00:04 +0200
Message-ID	<tXeba-2PV-29@gated-at.bofh.it> (permalink)
References	<tXaqR-ld-7@gated-at.bofh.it>
X-Original-To	kbuild test robot <lkp@intel.com>
User-Agent	Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1
MIME-Version	1.0
Content-Type	text/plain; charset="windows-1252"
Content-Transfer-Encoding	7bit
X-Originating-IP	[10.74.220.143]
X-Cfilter-Loop	Reflected
X-Mirapoint-Virus-Rapid-Raw	score=unknown(0), refid=str=0001.0A020201.595343AF.00EF,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-ID	f2c58e876b97d0cd298e8ae7dad307c5
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	66
Organization	linux.* mail to news gateway
X-Original-Cc	<mark.rutland@arm.com>, <linux-doc@vger.kernel.org>, <will.deacon@arm.com>, <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>, <kbuild-all@01.org>, <linux-arm-kernel@lists.infradead.org>
X-Original-Date	Wed, 28 Jun 2017 13:50:28 +0800
X-Original-Message-ID	<59d9ca29-6e57-3a9c-f6dc-fca3619dfacc@hisilicon.com>
X-Original-References	<201706280909.xG39IHY4%fengguang.wu@intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1676398

Show key headers only | View raw

Hi,

On 2017/6/28 9:49, kbuild test robot wrote:
> Hi Shaokun,
> 
> [auto build test ERROR on next-20170619]
> [also build test ERROR on v4.12-rc7]
> [cannot apply to linus/master linux/master arm64/for-next/core v4.12-rc6 v4.12-rc5 v4.12-rc4]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Shaokun-Zhang/Add-HiSilicon-SoC-uncore-Performance-Monitoring-Unit-driver/20170628-070841
> config: x86_64-allmodconfig (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/perf/hisilicon/hisi_uncore_pmu.c: In function 'hisi_read_scl_and_ccl_id':
>>> drivers/perf/hisilicon/hisi_uncore_pmu.c:72:10: error: implicit declaration of function 'read_cpuid_mpidr' [-Werror=implicit-function-declaration]
>      mpidr = read_cpuid_mpidr();
>              ^~~~~~~~~~~~~~~~
>>> drivers/perf/hisilicon/hisi_uncore_pmu.c:73:14: error: 'MPIDR_MT_BITMASK' undeclared (first use in this function)
>      if (mpidr & MPIDR_MT_BITMASK) {
>                  ^~~~~~~~~~~~~~~~
>    drivers/perf/hisilicon/hisi_uncore_pmu.c:73:14: note: each undeclared identifier is reported only once for each function it appears in
>>> drivers/perf/hisilicon/hisi_uncore_pmu.c:75:14: error: implicit declaration of function 'MPIDR_AFFINITY_LEVEL' [-Werror=implicit-function-declaration]
>        *scl_id = MPIDR_AFFINITY_LEVEL(mpidr, 3);
>                  ^~~~~~~~~~~~~~~~~~~~
>    cc1: some warnings being treated as errors
> 

Apologies for my modified drivers/perf/Kconfig for HISI_PMU.
It depends on ARM64 and i shall remove COMPILE_TEST to fix it.

Thanks.
Shaokun

> vim +/read_cpuid_mpidr +72 drivers/perf/hisilicon/hisi_uncore_pmu.c
> 
>     66	
>     67	/* Read Super CPU cluster and CPU cluster ID from MPIDR_EL1 */
>     68	void hisi_read_scl_and_ccl_id(u32 *scl_id, u32 *ccl_id)
>     69	{
>     70		u64 mpidr;
>     71	
>   > 72		mpidr = read_cpuid_mpidr();
>   > 73		if (mpidr & MPIDR_MT_BITMASK) {
>     74			if (scl_id)
>   > 75				*scl_id = MPIDR_AFFINITY_LEVEL(mpidr, 3);
>     76			if (ccl_id)
>     77				*ccl_id = MPIDR_AFFINITY_LEVEL(mpidr, 2);
>     78		} else {
> 
> ---
> 0-DAY kernel test infrastructure                Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
> 
> 
> 
> _______________________________________________
> linuxarm mailing list
> linuxarm@huawei.com
> http://rnd-openeuler.huawei.com/mailman/listinfo/linuxarm
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 2/6] drivers: perf: hisi: Add support for HiSilicon SoC  uncore PMU driver Zhangshaokun <zhangshaokun@hisilicon.com> - 2017-06-28 08:00 +0200

csiph-web