Re: [PATCH v3 1/2] spi: rockchip: Set GPIO_SS flag to enable Slave Select with GPIO CS

From	Doug Anderson <dianders@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] spi: rockchip: Set GPIO_SS flag to enable Slave Select with GPIO CS
Date	2017-06-28 07:40 +0200
Message-ID	<tXdRM-2J1-5@gated-at.bofh.it> (permalink)
References	<tXcVH-27M-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi,

On Tue, Jun 27, 2017 at 9:38 PM, Jeffy Chen <jeffy.chen@rock-chips.com> wrote:
> The rockchip spi still requires slave selection when using GPIO CS.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  drivers/spi/spi-rockchip.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
> index bab9b13..52ea160 100644
> --- a/drivers/spi/spi-rockchip.c
> +++ b/drivers/spi/spi-rockchip.c
> @@ -749,6 +749,7 @@ static int rockchip_spi_probe(struct platform_device *pdev)
>         master->transfer_one = rockchip_spi_transfer_one;
>         master->max_transfer_size = rockchip_spi_max_transfer_size;
>         master->handle_err = rockchip_spi_handle_err;
> +       master->flags = SPI_MASTER_GPIO_SS;
>
>         rs->dma_tx.ch = dma_request_chan(rs->dev, "tx");
>         if (IS_ERR(rs->dma_tx.ch)) {

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thread

[PATCH v3 1/2] spi: rockchip: Set GPIO_SS flag to enable Slave Select with GPIO CS Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-28 06:40 +0200
  [PATCH v3 2/2] spi: rockchip: Disable Runtime PM when chip select is asserted Jeffy Chen <jeffy.chen@rock-chips.com> - 2017-06-28 06:40 +0200
    Re: [PATCH v3 2/2] spi: rockchip: Disable Runtime PM when chip select  is asserted Doug Anderson <dianders@chromium.org> - 2017-06-28 07:40 +0200
      Re: [PATCH v3 2/2] spi: rockchip: Disable Runtime PM when chip  select is asserted Mark Brown <broonie@kernel.org> - 2017-06-28 20:50 +0200
    Applied "spi: rockchip: Disable Runtime PM when chip select is asserted" to the spi tree Mark Brown <broonie@kernel.org> - 2017-06-28 21:30 +0200
  Re: [PATCH v3 1/2] spi: rockchip: Set GPIO_SS flag to enable Slave  Select with GPIO CS Doug Anderson <dianders@chromium.org> - 2017-06-28 07:40 +0200
  Applied "spi: rockchip: Set GPIO_SS flag to enable Slave Select with GPIO CS" to the spi tree Mark Brown <broonie@kernel.org> - 2017-06-28 21:30 +0200

csiph-web