Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676324

RE: [PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro.

Show all headers | View raw

> -----Original Message-----
> From: Quytelda Kahja [mailto:quytelda@tamalin.org]
> Sent: Tuesday, June 27, 2017 5:18 PM
> To: Kershner, David A <David.Kershner@unisys.com>;
> gregkh@linuxfoundation.org
> Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; Quytelda
> Kahja <quytelda@tamalin.org>
> Subject: [PATCH] Replace the literal function name
> "visorbus_create_instance" with the format specifier "%s" so it can be
> dynamically filled by the __func__ macro.

I think the subject line got lost somehow, and should this have been a v2? 

Subject line should start with staging: unisys: visorbus: preferably.

David Kershner

> 
> Signed-off-by: Quytelda Kahja <quytelda@tamalin.org>
> ---
>  drivers/staging/unisys/visorbus/visorbus_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/unisys/visorbus/visorbus_main.c
> b/drivers/staging/unisys/visorbus/visorbus_main.c
> index 1c785dd19ddd..1c6dc3a3e64a 100644
> --- a/drivers/staging/unisys/visorbus/visorbus_main.c
> +++ b/drivers/staging/unisys/visorbus/visorbus_main.c
> @@ -1030,7 +1030,7 @@ visorbus_create_instance(struct visor_device
> *dev)
>  err_debugfs_dir:
>  	debugfs_remove_recursive(dev->debugfs_dir);
>  	kfree(hdr_info);
> -	dev_err(&dev->device, "visorbus_create_instance failed: %d\n",
> err);
> +	dev_err(&dev->device, "%s failed: %d\n", __func__, err);
>  	return err;
>  }
> 
> --
> 2.13.2

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Replace the literal function name "visorbus_create_instance" with the format specifier "%s" so it can be dynamically filled by the __func__ macro. Quytelda Kahja <quytelda@tamalin.org> - 2017-06-27 23:20 +0200
  RE: [PATCH] Replace the literal function name  "visorbus_create_instance" with the format specifier "%s" so it can be  dynamically filled by the __func__ macro. "Kershner, David A" <David.Kershner@unisys.com> - 2017-06-28 04:40 +0200

csiph-web