Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676311

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

From "Madhani, Himanshu" <Himanshu.Madhani@cavium.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock
Date 2017-06-28 03:50 +0200
Message-ID <tXahb-i0-7@gated-at.bofh.it> (permalink)
References <tVr2O-7yl-15@gated-at.bofh.it> <tXa7w-eJ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Martin,

On 6/27/17, 6:32 PM, "Martin K. Petersen" <martin.petersen@oracle.com> wrote:

    
    > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the
    > qpair->qp_lock but do access members of the qpair before having the lock.
    > Re-order the locking sequence to have all read and write access to qpair
    > members under the qpair->qp_lock.
    
    Cavium folks, please review!

I am testing it internally, will update by tomorrow. 
    
    -- 
    Martin K. Petersen	Oracle Linux Engineering
    
Thanks,
Himanshu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-23 09:20 +0200
  Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-06-28 03:40 +0200
    Re: [PATCH v2] qla2xxx: Protect access to qpair members with  qpair->qp_lock "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2017-06-28 03:50 +0200
  Re: [PATCH v2] qla2xxx: Protect access to qpair members with  qpair->qp_lock "Madhani, Himanshu" <Himanshu.Madhani@cavium.com> - 2017-06-28 20:00 +0200
  Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-07-01 23:00 +0200

csiph-web