Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1678583

[PATCH] phy: phy-twl4030-usb: silence an uninitialized variable warning

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject [PATCH] phy: phy-twl4030-usb: silence an uninitialized variable warning
Date 2017-06-30 10:10 +0200
Message-ID <tXZa1-2WX-13@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


The "check" variable isn't necessarily initialized when we print it out
in the debugging messages.  It's a pretty haphazard affair and it
doesn't matter very much what we initialize "check" to.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/phy/ti/phy-twl4030-usb.c b/drivers/phy/ti/phy-twl4030-usb.c
index 2990b3965460..0e9013868188 100644
--- a/drivers/phy/ti/phy-twl4030-usb.c
+++ b/drivers/phy/ti/phy-twl4030-usb.c
@@ -185,7 +185,7 @@ struct twl4030_usb {
 static int twl4030_i2c_write_u8_verify(struct twl4030_usb *twl,
 		u8 module, u8 data, u8 address)
 {
-	u8 check;
+	u8 check = 0xFF;
 
 	if ((twl_i2c_write_u8(module, data, address) >= 0) &&
 	    (twl_i2c_read_u8(module, &check, address) >= 0) &&

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] phy: phy-twl4030-usb: silence an uninitialized variable  warning Dan Carpenter <dan.carpenter@oracle.com> - 2017-06-30 10:10 +0200

csiph-web