Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1678571

[PATCH] dmaengine: zx: add check on platform_get_irq return value

From "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Newsgroups linux.kernel
Subject [PATCH] dmaengine: zx: add check on platform_get_irq return value
Date 2017-06-30 10:00 +0200
Message-ID <tXZ0l-2EL-3@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


Check return value from call to platform_get_irq(),
so in case of failure print error message and propagate
the return value.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/dma/zx_dma.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/dma/zx_dma.c b/drivers/dma/zx_dma.c
index 2bb6953..26196de 100644
--- a/drivers/dma/zx_dma.c
+++ b/drivers/dma/zx_dma.c
@@ -786,6 +786,11 @@ static int zx_dma_probe(struct platform_device *op)
 	}
 
 	d->irq = platform_get_irq(op, 0);
+	if (d->irq < 0) {
+		dev_err(&op->dev, "failed to get IRQ: %d\n", d->irq);
+		return d->irq;
+	}
+
 	ret = devm_request_irq(&op->dev, d->irq, zx_dma_int_handler,
 			       0, DRIVER_NAME, d);
 	if (ret)
-- 
2.5.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] dmaengine: zx: add check on platform_get_irq return value "Gustavo A. R. Silva" <garsilva@embeddedor.com> - 2017-06-30 10:00 +0200

csiph-web