Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media

From	Johannes Thumshirn <jthumshirn@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media
Date	2017-06-30 09:30 +0200
Message-ID	<tXYxk-2tg-13@gated-at.bofh.it> (permalink)
References	<tUIS7-3AK-29@gated-at.bofh.it> <tVZHb-3U2-9@gated-at.bofh.it> <tXEfg-5VQ-23@gated-at.bofh.it> <tXL74-1Tp-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 29, 2017 at 10:01:05AM -0700, Stephen Hemminger wrote:
> If you read Linus's comments on version.
> Driver version is meaningless and there is a desire to rip it out of all
> drivers. The reason is that drivers must always behave the same, i.e you
> can't use version to change API/ABI behavior. 

Indeed this causes more harm than good. We had support calls regarding the
mlx4 driver because of not incremented MODLE_VERSION()s. If we follow your
and Linus' path we shouldn't just get rid of the KERNEL_VERSION() usage
in media and replace it with a new version, but kill all the versioning
stuff out of media (and others) except for maybe the HW version.

> Any upstream driver should never use KERNEL_VERSION().

Exactly my reasoning.

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION abuse in media Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-21 10:10 +0200
  [PATCH RESEND 1/7] [media] media: introduce MEDIA_REVISION macro Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-21 10:10 +0200
  [PATCH RESEND 3/7] [media] media: document the use of MEDIA_REVISION instead of KERNEL_VERSION Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-21 10:20 +0200
  [PATCH RESEND 7/7] staging/atomisp: use MEDIA_VERSION instead of KERNEL_VERSION Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-21 10:20 +0200
  [PATCH RESEND 5/7] [media] media: s3c-camif: Use MEDIA_REVISON instead of KERNEL_VERSION Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-21 10:20 +0200
  [PATCH RESEND 2/7] video: fbdev: don't use KERNEL_VERSION macro for MEDIA_REVISION Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-21 10:20 +0200
  Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end  KENREL_VERSION abuse in media Mauro Carvalho Chehab <mchehab@s-opensource.com> - 2017-06-24 22:20 +0200
    Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION  abuse in media Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-29 11:50 +0200
      Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end  KENREL_VERSION abuse in media Stephen Hemminger <stephen@networkplumber.org> - 2017-06-29 19:10 +0200
        Re: [PATCH RESEND 0/7] Introduce MEDIA_VERSION to end KENREL_VERSION  abuse in media Johannes Thumshirn <jthumshirn@suse.de> - 2017-06-30 09:30 +0200

csiph-web