Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678461

Re: [RFC 0/5] drivers: Add boot constraints core

From Chen-Yu Tsai <wens@csie.org>
Newsgroups linux.kernel
Subject Re: [RFC 0/5] drivers: Add boot constraints core
Date 2017-06-30 06:10 +0200
Message-ID <tXVpN-np-45@gated-at.bofh.it> (permalink)
References (2 earlier) <tXIVA-mS-17@gated-at.bofh.it> <tXJeX-IJ-31@gated-at.bofh.it> <tXUDp-8jG-15@gated-at.bofh.it> <tXUWK-8qf-13@gated-at.bofh.it> <tXVg5-8wu-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Fri, Jun 30, 2017 at 11:55 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 30-06-17, 11:33, Chen-Yu Tsai wrote:
>> AFAIK regulator constraints are supposed to satisfy all users of it.
>
> Right.
>
>> >> >Let me try with an example. A regulator is shared between LCD and DMA
>> >> >controller.
>> >> >
>> >> >Operable ranges of the regulator: 1.8 - 3.0 V
>> >> >Range required by LCD: 2.0 - 3.0 V
>> >> >Range required by DMA: 1.8 - 2.5 V
>>
>> So for the example here, the regulator constraint should be 2.5 - 3.0 V,
>> or the intersection of all voltage requirements.
>
> Had a look at regulator_check_consumers() and the range selected by it
> is the *highest* min_uV and *lowest* max_uV, to find that intersection
> point.
>
> For LCD: min_uV = 2.0 V, max_uV = 3.0 V
> For DMA: min_uV = 1.8 V, max_uV = 2.5 V
>
> Highest min_uV = 2.0 V
> Lowest max_uV = 2.5 V
>
> And so I mentioned the regulator's final range (that satisfies all
> consumers) is 2 - 2.5 V.
>
> Why do you say it should be 2.5 - 3.0 V ?

You are right. It should be 2.0 - 2.5 V. Haven't had my coffee this
morning. :(

I also want to mention that for DT based platforms, this constraint
should already be set in the device tree for the regulator, so the
scenario where DMA comes up and sets a voltage level that LCD cannot
use should not even be possible.

ChenYu

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-28 12:30 +0200
  [RFC 1/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-28 12:30 +0200
    Re: [RFC 1/5] drivers: Add boot constraints core Randy Dunlap <rdunlap@infradead.org> - 2017-06-28 18:00 +0200
      Re: [RFC 1/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-29 06:00 +0200
        Re: [RFC 1/5] drivers: Add boot constraints core Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-29 15:00 +0200
          Re: [RFC 1/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-29 17:00 +0200
  Re: [RFC 0/5] drivers: Add boot constraints core "Enrico Weigelt, metux IT consult" <enrico.weigelt@gr13.net> - 2017-06-29 14:50 +0200
    Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-29 16:50 +0200
      Re: [RFC 0/5] drivers: Add boot constraints core "Enrico Weigelt, metux IT consult" <enrico.weigelt@gr13.net> - 2017-06-29 17:10 +0200
        Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-30 05:20 +0200
          Re: [RFC 0/5] drivers: Add boot constraints core Chen-Yu Tsai <wens@csie.org> - 2017-06-30 05:40 +0200
            Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-30 06:00 +0200
              Re: [RFC 0/5] drivers: Add boot constraints core Chen-Yu Tsai <wens@csie.org> - 2017-06-30 06:10 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-30 06:20 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Chen-Yu Tsai <wens@csie.org> - 2017-06-30 06:30 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-30 07:20 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Chen-Yu Tsai <wens@csie.org> - 2017-06-30 08:40 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-30 10:50 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Mark Brown <broonie@kernel.org> - 2017-06-30 14:20 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-07-03 08:20 +0200
                Re: [RFC 0/5] drivers: Add boot constraints core Mark Brown <broonie@kernel.org> - 2017-06-30 14:20 +0200
  Re: [RFC 0/5] drivers: Add boot constraints core Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-29 14:50 +0200
    Re: [RFC 0/5] drivers: Add boot constraints core "Enrico Weigelt, metux IT consult" <enrico.weigelt@gr13.net> - 2017-06-29 15:10 +0200
    Re: [RFC 0/5] drivers: Add boot constraints core Viresh Kumar <viresh.kumar@linaro.org> - 2017-06-29 17:00 +0200
      Re: [RFC 0/5] drivers: Add boot constraints core Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-06-29 17:50 +0200
        Re: [RFC 0/5] drivers: Add boot constraints core Stephen Boyd <sboyd@codeaurora.org> - 2017-06-29 23:10 +0200

csiph-web