Inconsistency in scripts/checkpatch.pl

From	Larry Finger <Larry.Finger@lwfinger.net>
Newsgroups	linux.kernel
Subject	Inconsistency in scripts/checkpatch.pl
Date	2017-06-30 03:30 +0200
Message-ID	<tXSUV-74w-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Andy and Joe,

In some new rtlwifi code, I get the following for one of the new macros:

CHECK: Macro argument '__h2c' may be better as '(__h2c)' to avoid precedence issues
#45005: FILE: 
drivers/net/wireless/realtek/rtlwifi/halmac/halmac_original_h2c_nic.h:1163:
+#define AOAC_RSVD_PAGE3_GET_LOC_AOAC_REPORT(__h2c)                     \
+       LE_BITS_TO_4BYTE(__h2c + 0X00, 16, 8)

When I make that change, I get

CHECK: No space is necessary after a cast
#45004: FILE: 
drivers/net/wireless/realtek/rtlwifi/halmac/halmac_original_h2c_nic.h:1162:
+       LE_BITS_TO_4BYTE((__h2c) + 0X00, 16, 8)

Which CHECK should I fix? To my eye, the second form is the false positive.

Larry

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Inconsistency in scripts/checkpatch.pl Larry Finger <Larry.Finger@lwfinger.net> - 2017-06-30 03:30 +0200
  Re: Inconsistency in scripts/checkpatch.pl Joe Perches <joe@perches.com> - 2017-06-30 05:20 +0200

csiph-web