Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678238

Re: [PATCH 2/6] clk: at91: add audio pll clock driver

Show all headers | View raw

Hi,

On 29/06/2017 at 16:47:58 -0500, Rob Herring wrote:
> On Fri, Jun 23, 2017 at 11:00:55AM +0200, Quentin Schulz wrote:
> > From: Nicolas Ferre <nicolas.ferre@atmel.com>
> > 
> > This new clock driver set allows to have a fractional divided clock that
> > would generate a precise clock particularly suitable for audio
> > applications.
> > 
> > The main audio pll clock has two children clocks: one that is connected
> > to the PMC, the other that can directly drive a pad. As these two routes
> > have different enable bits and different dividers and divider formula,
> > they are handled by two different drivers. Each of them could modify the
> > rate of the main audio pll parent.
> > The main audio pll clock can output 620MHz to 700MHz.
> > 
> > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> > ---
> >  .../devicetree/bindings/clock/at91-clock.txt       |  10 +
> 
> It would be nice to see at91 to transition away from a node per clock to 
> just clock controller nodes. In any case:
> 

Yes, that is exactly our plan.

> Acked-by: Rob Herring <robh@kernel.org>
> 
> >  arch/arm/mach-at91/Kconfig                         |   4 +
> >  drivers/clk/at91/Makefile                          |   2 +
> >  drivers/clk/at91/clk-audio-pll-pad.c               | 204 ++++++++++++++++++
> >  drivers/clk/at91/clk-audio-pll-pmc.c               | 175 +++++++++++++++
> >  drivers/clk/at91/clk-audio-pll.c                   | 237 +++++++++++++++++++++
> >  include/linux/clk/at91_pmc.h                       |  25 +++
> >  sound/soc/atmel/atmel-classd.c                     |  20 +-
> >  8 files changed, 658 insertions(+), 19 deletions(-)
> >  create mode 100644 drivers/clk/at91/clk-audio-pll-pad.c
> >  create mode 100644 drivers/clk/at91/clk-audio-pll-pmc.c
> >  create mode 100644 drivers/clk/at91/clk-audio-pll.c

-- 
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/6] clk: at91: add audio pll clock driver Quentin Schulz <quentin.schulz@free-electrons.com> - 2017-06-23 11:10 +0200
  Re: [PATCH 2/6] clk: at91: add audio pll clock driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-23 17:50 +0200
  Re: [PATCH 2/6] clk: at91: add audio pll clock driver Rob Herring <robh@kernel.org> - 2017-06-29 23:50 +0200
    Re: [PATCH 2/6] clk: at91: add audio pll clock driver Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-30 00:20 +0200

csiph-web