Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/6] net: stmmac: support future possible different internal phy mode
Date	2017-06-29 22:10 +0200
Message-ID	<tXNVg-3KB-15@gated-at.bofh.it> (permalink)
References	<tWV8t-6Z7-9@gated-at.bofh.it> <tXKum-1qg-15@gated-at.bofh.it> <tXL73-1Tp-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Corentin Labbe <clabbe.montjoie@gmail.com>
Date: Thu, 29 Jun 2017 19:02:38 +0200

> On Thu, Jun 29, 2017 at 12:23:49PM -0400, David Miller wrote:
>> From: Corentin Labbe <clabbe.montjoie@gmail.com>
>> Date: Tue, 27 Jun 2017 11:28:01 +0200
>> 
>> > The current way to find if the phy is internal is to compare DT phy-mode
>> > and emac_variant/internal_phy.
>> > But it will negate a possible future SoC where an external PHY use the
>> > same phy mode than the internal one.
>> > 
>> > By using phy-mode = "internal" we permit to have an external PHY with
>> > the same mode than the internal one.
>> > 
>> > Reported-by: André Przywara <andre.przywara@arm.com>
>> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
>> 
>> Series applied.
>> 
>> Please provide a proper "[PATCH 0/n] " header posting next time.
> 
> Sorry could you wait for applying, there are a parallel thread (http://www.spinics.net/lists/devicetree/msg183520.html) and it seems finaly that internal could not be the good way to do it.
> 
> Regards
> Sorry again, I should have sent a comment for waiting.

Please send me a revert patch, when I say I've applied it I already pushed
it out to my GIT tree.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/6] net: stmmac: support future possible different internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-27 11:40 +0200
  [PATCH 5/6] arm: sun8i: nanopi-neo: use internal phy-mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-27 11:40 +0200
  [PATCH 2/6] arm: sun8i: orangepipc: use internal phy-mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-27 11:40 +0200
  [PATCH 6/6] arm: sun8i: orangepi-2: use internal phy-mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-27 11:40 +0200
  [PATCH 4/6] arm: sun8i: orangepi-one: use internal phy-mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-27 11:40 +0200
  Re: [PATCH 1/6] net: stmmac: support future possible different  internal phy mode David Miller <davem@davemloft.net> - 2017-06-29 18:30 +0200
    Re: [linux-sunxi] Re: [PATCH 1/6] net: stmmac: support future  possible different internal phy mode icenowy@aosc.io - 2017-06-29 18:50 +0200
    Re: [PATCH 1/6] net: stmmac: support future possible different  internal phy mode Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-06-29 19:10 +0200
      Re: [PATCH 1/6] net: stmmac: support future possible different  internal phy mode David Miller <davem@davemloft.net> - 2017-06-29 22:10 +0200

csiph-web