Re: [PATCH V4 00/12] blktrace: output cgroup info

From	Shaohua Li <shli@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH V4 00/12] blktrace: output cgroup info
Date	2017-06-29 20:40 +0200
Message-ID	<tXMwb-2FO-39@gated-at.bofh.it> (permalink)
References	(1 earlier) <tXppZ-t5-103@gated-at.bofh.it> <tXppZ-t5-105@gated-at.bofh.it> <tXppZ-t5-101@gated-at.bofh.it> <tXpJi-Rv-45@gated-at.bofh.it> <tXse7-2gi-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Jun 28, 2017 at 02:57:38PM -0600, Jens Axboe wrote:
> On 06/28/2017 12:11 PM, Tejun Heo wrote:
> > Hello,
> > 
> > On Wed, Jun 28, 2017 at 10:54:28AM -0600, Jens Axboe wrote:
> >>>> Series looks fine to me. I don't know how you want to split or funnel it,
> >>>> since it touches multiple different parts. Would it make sense to split this
> >>>> series into two - one for the kernfs changes, and then a subsequent block
> >>>> series that depend on that?
> >>>
> >>> What's the best practice to do this without building errors? Ask Tejun
> >>> to merge the first 7 patches first?
> >>
> >> Yes, and then resend the block patches, just noting that dependency. Then
> >> we can funnel them in like that.
> > 
> > I wonder whether it'd be a lot easier to route the whole series
> > through one tree, most likely block.  Greg, would that be okay with
> > you?  Alternatively, we can route the whole thing through driver tree
> > if Jens is okay with that.
> 
> Personally I don't care that much, but the risk of conflicts is much
> higher on the block side, than on the kernfs side. So might be the
> path of less resistance to pull it through the block tree. And I'd be
> happy to do that, if the sign offs on the kernfs side are sufficient.

Jens,
Now we have the stamps, could you please queue the patches in your tree?

For the patch 10, please drop it right now. With Christoph's integrity patch,
we only need to free cgroup info in bio_endio. I'll resend a patch.

Thanks,
Shaohua

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V4 00/12] blktrace: output cgroup info Jens Axboe <axboe@kernel.dk> - 2017-06-28 20:00 +0200
  Re: [PATCH V4 00/12] blktrace: output cgroup info Tejun Heo <tj@kernel.org> - 2017-06-28 20:20 +0200
    Re: [PATCH V4 00/12] blktrace: output cgroup info Jens Axboe <axboe@kernel.dk> - 2017-06-28 23:00 +0200
      Re: [PATCH V4 00/12] blktrace: output cgroup info Tejun Heo <tj@kernel.org> - 2017-06-28 23:30 +0200
        Re: [PATCH V4 00/12] blktrace: output cgroup info Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 15:00 +0200
      Re: [PATCH V4 00/12] blktrace: output cgroup info Shaohua Li <shli@kernel.org> - 2017-06-29 20:40 +0200

csiph-web