Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1678078

Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

Show all headers | View raw

On 6/29/2017 12:11 PM, Allen Hubbe wrote:
> Nak.  This breaks a work around for stability issues on some hardware.  I am ok with changing the comment to say, this is only supported when called after link up.  I would still like to allow these to be called at any time.  Specific hardware drivers like Switchtec may return an error.  Upstream drivers, of course, should call these after link up: patch 5/16 part of this set looks good.

If absolutely necessary I can leave this out. But in terms of interface 
design it's _so_ much better to have it in. This change would bring the 
score from a 3 to a 5 on Rusty Russel's Hard to Misuse ranking[1]. To 
quote Rusty:

"3. Read the documentation and you'll get it right.
People only read instructions after they've already tied themselves into 
a knot. Then they skim them for keywords and don't read your warnings. I 
don't give an example of this; if this is the best an interface can get 
do, it's in trouble."

Can someone not just fix the out-of-tree code? And since when is 
out-of-tree code reasonable justification for what's done in upstream?

Logan

[1]http://ozlabs.org/~rusty/index.cgi/tech/2008-03-30.html

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 05:30 +0200
  RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-06-29 20:20 +0200
    Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count  and mw_get_align Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 21:10 +0200
      Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count  and mw_get_align Logan Gunthorpe <logang@deltatee.com> - 2017-06-29 22:20 +0200
        RE: [PATCH 06/16] ntb: add check and comment for link up to  mw_count and mw_get_align "Hubbe, Allen" <Allen.Hubbe@dell.com> - 2017-06-29 23:30 +0200
        RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-06-29 23:40 +0200
          Re: [PATCH 06/16] ntb: add check and comment for link up to mw_count  and mw_get_align Logan Gunthorpe <logang@deltatee.com> - 2017-06-30 00:20 +0200
      RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align "Allen Hubbe" <Allen.Hubbe@dell.com> - 2017-06-29 22:20 +0200

csiph-web