Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1678017

Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver

From Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups linux.kernel
Subject Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver
Date 2017-06-29 20:10 +0200
Message-ID <tXM38-2wf-13@gated-at.bofh.it> (permalink)
References <tUpPr-84z-1@gated-at.bofh.it> <tUpPr-84z-19@gated-at.bofh.it> <tX5Ky-5OX-11@gated-at.bofh.it> <tXIVA-mS-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello,

On Thu, Jun 29, 2017 at 02:40:44PM +0000, Pierre Yves MORDRET wrote:
> >> +	/* Arbitration loss */
> >> +	if (status & STM32F7_I2C_ISR_ARLO) {
> >> +		dev_err(dev, "<%s>: Arbitration loss\n", __func__);
> > 
> > Drop this. Arbitration loss is not an error and it shouldn't pollute the
> > kernel log.
> > 
> 
> I would like to keep it as indication though.
> Agree with dev_warn ?

No, dev_debug is ok.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 0/5] Add support for the STM32F7 I2C Pierre-Yves MORDRET <pierre-yves.mordret@st.com> - 2017-06-20 13:50 +0200
  [PATCH v2 5/5] ARM: dts: stm32: Add I2C1 support for STM32F746 eval board Pierre-Yves MORDRET <pierre-yves.mordret@st.com> - 2017-06-20 13:50 +0200
  [PATCH v2 1/5] dt-bindings: i2c-stm32: Document the STM32F7 I2C bindings Pierre-Yves MORDRET <pierre-yves.mordret@st.com> - 2017-06-20 13:50 +0200
    Re: [PATCH v2 1/5] dt-bindings: i2c-stm32: Document the STM32F7 I2C  bindings Rob Herring <robh@kernel.org> - 2017-06-22 23:10 +0200
  [PATCH v2 2/5] i2c: i2c-stm32f4: use generic definition of speed enum Pierre-Yves MORDRET <pierre-yves.mordret@st.com> - 2017-06-20 13:50 +0200
  [PATCH v2 3/5] i2c: i2c-stm32f7: add driver Pierre-Yves MORDRET <pierre-yves.mordret@st.com> - 2017-06-20 13:50 +0200
    Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-06-27 23:00 +0200
      Re: [PATCH v2 3/5] i2c: i2c-stm32f7: add driver Uwe Kleine-König          <u.kleine-koenig@pengutronix.de> - 2017-06-29 20:10 +0200
  [PATCH v2 4/5] ARM: dts: stm32: Add I2C1 support for STM32F746 SoC Pierre-Yves MORDRET <pierre-yves.mordret@st.com> - 2017-06-20 13:50 +0200

csiph-web