Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677909
| From | Kees Cook <keescook@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h |
| Date | 2017-06-29 18:20 +0200 |
| Message-ID | <tXKkG-1nd-35@gated-at.bofh.it> (permalink) |
| References | <tXBhn-47z-3@gated-at.bofh.it> <tXDCy-5Ff-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, Jun 29, 2017 at 2:03 AM, Daniel Borkmann <daniel@iogearbox.net> wrote: > On 06/29/2017 08:29 AM, Michael Ellerman wrote: >> >> Currently code that wants to use set_memory_ro() etc, needs to include >> asm/set_memory.h, which doesn't exist on all arches. Some code knows >> it only builds on arches which have the header, other code guards the >> inclusion with an #ifdef, neither is ideal. >> >> So create linux/set_memory.h. This always exists, so users don't need >> an #ifdef just to include the header. >> >> When CONFIG_ARCH_HAS_SET_MEMORY=y it includes asm/set_memory.h, >> otherwise it provides empty non-failing implementations. >> >> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> > > > Looks good to me, thanks! > > Acked-by: Daniel Borkmann <daniel@iogearbox.net> > > I'm fine if Andrew or Kees picks up the bpf patch as well, I think > there shouldn't be any conflict with net-next on this one (and even > if so, then looks trivial to resolve). I nominate Andrew. ;) This should go in early in the merge window and the users can go late in the window. If Andrew has enough to do, I can carry it too; just say the word. This is a sane addition and allows for lines-of-code reduction in a few places. Thanks! Acked-by: Kees Cook <keescook@chromium.org> -Kees -- Kees Cook Pixel Security
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 1/4] Provide linux/set_memory.h Michael Ellerman <mpe@ellerman.id.au> - 2017-06-29 08:40 +0200
[RFC PATCH 3/4] module: Use linux/set_memory.h Michael Ellerman <mpe@ellerman.id.au> - 2017-06-29 08:40 +0200
[RFC PATCH 4/4] bpf: Use linux/set_memory.h Michael Ellerman <mpe@ellerman.id.au> - 2017-06-29 08:40 +0200
Re: [kernel-hardening] [RFC PATCH 4/4] bpf: Use linux/set_memory.h Daniel Borkmann <daniel@iogearbox.net> - 2017-06-29 11:00 +0200
Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h Daniel Borkmann <daniel@iogearbox.net> - 2017-06-29 11:10 +0200
Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h Kees Cook <keescook@chromium.org> - 2017-06-29 18:20 +0200
Re: [kernel-hardening] [RFC PATCH 1/4] Provide linux/set_memory.h Michael Ellerman <mpe@ellerman.id.au> - 2017-06-30 03:50 +0200
Re: [RFC PATCH 1/4] Provide linux/set_memory.h Laura Abbott <labbott@redhat.com> - 2017-06-29 18:50 +0200
csiph-web