Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677932

Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board

Show all headers | View raw

On Wed, 2017-06-28 at 17:50 -0500, Rob Herring wrote:
> > > > +                       #clock-cells = <0>;
> > > > +                       compatible = "fixed-clock";
> > > > +                       clock-frequency = <1000000000>;
> > > > +               };
> > > > +
> > > > +               core_intc: archs-intc@cpu {
> > > 
> > > cpu is not a valid unit-address. How are these interrupt
> > > controllers addressed?
> > 
> > We have per-core INTC so each core communicates to its own INTC and
> > there's no way
> > for any core to talk with INTC of another core.
> > 
> > But then we have the next level INTC which is IDU (Interrupt
> > Distribution Unit)
> > which dispatches "common" IRQs to different upstream per-core INTC,
> > see below its node. 
> 
> Okay, I'd just do "cpu-interrupt-controller" for the node name then. 
> There doesn't seem to be an easy way to use just "interrupt-
> controller" 
> since you have 2 nodes at the same level and no unit-address (i.e. a 
> reg property).
> 

To be more clarify, what is better way do describe such hardware in
device tree?

-------------    -------------  
| cpu core 0|    | cpu core 1|  
-------------    -------------  
| interrupt |    | interrupt |  
| controller|    | controller|  
|     0     |    |     1     |  
-------------    -------------  
      ^                ^
      |                |
             -----------
      |      |
----------------
|   interrupt  |
| distribution |
|     unit     |
----------------
      ^
      |
      |<--other devices interrupt lines

We can't just create a node for each core interrupt controller because
we wouldn't able to specify which one is parent for interrupt
distribution unit:

------------>>>-------------
cpus {
    cpu@0 { intc@0 };
    cpu@1 { intc@1 };
};

interrupt-distribution-unit {
    interrupt-parent = ????
};
------------>>>-------------

Should we simply create one core interrupt controller node for all cpus
(instead of one per each cpu core), or where is a better option?

-- 
 Eugeniy Paltsev

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/3 v6] hsdk: initial port for HSDK board Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-06-26 17:20 +0200
  [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-06-26 17:20 +0200
    Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board Rob Herring <robh+dt@kernel.org> - 2017-06-26 18:00 +0200
      Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board Alexey Brodkin <Alexey.Brodkin@synopsys.com> - 2017-06-26 18:30 +0200
        stdout-path (was Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK  board) Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-06-27 06:30 +0200
        Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board Rob Herring <robh@kernel.org> - 2017-06-29 01:00 +0200
          Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-06-29 18:40 +0200
    Re: [PATCH 3/3 v6] ARC: hsdk: initial port for HSDK board Vineet Gupta <Vineet.Gupta1@synopsys.com> - 2017-06-29 09:30 +0200
  [PATCH 1/3 v6] ARC: Set IO-coherency aperture base to LINUX_LINK_BASE Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-06-26 17:20 +0200
  [PATCH 2/3 v6] ARC: Decouple linux kernel memory address and link address Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> - 2017-06-26 17:20 +0200

csiph-web