Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677901

RE: [PATCH] perf tools: set no branch type for dummy event in PT

From "Liang, Kan" <kan.liang@intel.com>
Newsgroups linux.kernel
Subject RE: [PATCH] perf tools: set no branch type for dummy event in PT
Date 2017-06-29 18:00 +0200
Message-ID <tXK1m-11t-45@gated-at.bofh.it> (permalink)
References <tXmim-7Xs-21@gated-at.bofh.it> <tXJyj-P8-43@gated-at.bofh.it> <tXJHZ-Sn-37@gated-at.bofh.it> <tXJHZ-Sn-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> 
> On Thu, Jun 29, 2017 at 03:31:45PM +0000, Liang, Kan wrote:
> 
> SNIP
> 
> > > >  static int intel_pt_recording_options(struct auxtrace_record *itr,
> > > >  				      struct perf_evlist *evlist,
> > > >  				      struct record_opts *opts) @@ -701,6
> +717,8 @@ static
> > > > int intel_pt_recording_options(struct
> > > auxtrace_record *itr,
> > > >  				perf_evsel__set_sample_bit(switch_evsel,
> > > TIME);
> > > >  				perf_evsel__set_sample_bit(switch_evsel,
> > > CPU);
> > > >
> > > > +				add_no_lbr_config_term(&switch_evsel-
> > > >config_terms);
> > > > +
> > >
> > > hum, why can't you change the sample bit directly? with:
> > >
> > > 			perf_evsel__reset_sample_bit(switch_evsel,
> > > BRANCH_STACK);
> >
> > It will be overwrite in perf_evsel__config.
> >
> 
> where? you set the evsel->no_aux_samples

Yes for switch_evsel, but no for tracking_evsel.

If it's only for switch_evsel, yes, we can change the sample bit directly.
But I think we should use the same method for both of them.

Thanks,
Kan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf tools: set no branch type for dummy event in PT kan.liang@intel.com - 2017-06-28 16:40 +0200
  Re: [PATCH] perf tools: set no branch type for dummy event in PT Jiri Olsa <jolsa@redhat.com> - 2017-06-29 17:30 +0200
    Re: [PATCH] perf tools: set no branch type for dummy event in PT Jiri Olsa <jolsa@redhat.com> - 2017-06-29 17:40 +0200
      RE: [PATCH] perf tools: set no branch type for dummy event in PT "Liang, Kan" <kan.liang@intel.com> - 2017-06-29 18:00 +0200
        Re: [PATCH] perf tools: set no branch type for dummy event in PT Jiri Olsa <jolsa@redhat.com> - 2017-06-30 09:10 +0200
          RE: [PATCH] perf tools: set no branch type for dummy event in PT "Liang, Kan" <kan.liang@intel.com> - 2017-06-30 16:10 +0200
    RE: [PATCH] perf tools: set no branch type for dummy event in PT "Liang, Kan" <kan.liang@intel.com> - 2017-06-29 17:40 +0200

csiph-web