Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1677776

Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1

From Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Newsgroups linux.kernel
Subject Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips using the VSP1
Date 2017-06-29 16:10 +0200
Message-ID <tXIiR-80-5@gated-at.bofh.it> (permalink)
References <tXIiR-80-7@gated-at.bofh.it> <tXIiR-80-9@gated-at.bofh.it>
Organization Ideas on Board

Show all headers | View raw


> @@ -658,10 +660,14 @@ static irqreturn_t rcar_du_crtc_irq(int irq, void *arg)
>  	rcar_du_crtc_write(rcrtc, DSRCR, status & DSRCR_MASK);
>  
>  	if (status & DSSR_FRM) {
> -		drm_crtc_handle_vblank(&rcrtc->crtc);
> -
> -		if (rcdu->info->gen < 3)
> +		/*
> +		 * Gen 3 vblank and page flips are handled through the VSP
> +		 * completion handler
> +		 */
> +		if (rcdu->info->gen < 3) {

Of course as is obvious immediately after hitting send, this check was supposed
to be removed now that the interrupt is not registered.

Sorry for the noise and pre-released patch!

--
Kieran

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v1 2/2] drm: rcar-du: Repair vblank for DRM page flips  using the VSP1 Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> - 2017-06-29 16:10 +0200

csiph-web