Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1677826

Re: [PATCH 14/14] staging: ccree: fix block comment style

Show all headers | View raw

On Tue, Jun 27, 2017 at 9:27 AM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> Align block comments according to coding style.
>
> Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
> ---
>  drivers/staging/ccree/cc_hw_queue_defs.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h b/drivers/staging/ccree/cc_hw_queue_defs.h
> index f11487a..e6b8cea 100644
> --- a/drivers/staging/ccree/cc_hw_queue_defs.h
> +++ b/drivers/staging/ccree/cc_hw_queue_defs.h
> @@ -23,8 +23,8 @@
>  #include <linux/bitfield.h>
>
>  /******************************************************************************
> -*                              DEFINITIONS
> -******************************************************************************/
> + *                             DEFINITIONS
> + ******************************************************************************/

I think if you change to the preferred block comment format, you
should also drop these lines full of asterisks. I'm not sure why a
multi-line comment is warranted here, anyway.

Frans

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/14] staging: ccree: coding style fixes Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:30 +0200
  [PATCH 14/14] staging: ccree: fix block comment style Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:30 +0200
    Re: [PATCH 14/14] staging: ccree: fix block comment style Frans Klaver <fransklaver@gmail.com> - 2017-06-29 16:40 +0200
  [PATCH 12/14] staging: ccree: remove unused type CCFipsSyncStatus_t Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:30 +0200
  [PATCH 09/14] staging: ccree: remove custom type tdes_keys_t Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:30 +0200
  [PATCH 07/14] staging: ccree: remove comparisons to NULL Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:30 +0200
  [PATCH 10/14] staging: ccree: remove custom type ssi_fips_error_t Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:40 +0200
  [PATCH 04/14] staging: ccree: remove redundant blank lines Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:40 +0200
  [PATCH 11/14] staging: ccree: remove custom type ssi_fips_state_t Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:40 +0200
  [PATCH 06/14] staging: ccree: fix unmatched if/else braces Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:40 +0200
  [PATCH 05/14] staging: ccree: no need for braces for single statements Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:40 +0200
  [PATCH 03/14] staging: ccree: fix else placement Gilad Ben-Yossef <gilad@benyossef.com> - 2017-06-27 09:40 +0200

csiph-web