Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1677744

[PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong

Path csiph.com!usenet.pasdenom.info!aioe.org!bofh.it!news.nic.it!robomod
From Jaya Durga <rjdurga@gmail.com>
Newsgroups linux.kernel
Subject [PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is usually wrong
Date Thu, 29 Jun 2017 15:10:03 +0200
Message-ID <tXHmP-81e-29@gated-at.bofh.it> (permalink)
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=E/45oSBQhHGzvIBD0fFsRoAZu5iWGPECOZWz87TbH4A=; b=gu6RAG8rPqJDLfhi0nf/dIKhGKs4lbx592lfeXLRrr5Feky1W3K46kYICE659Ff/MQ F0a9a1mrO7VUiA8ZUHbbH9vUz15bcABwg8BUL169WyHoQxA2AM4xXbgQnxHb60tC4wm1 ez8duJN9nw4ZN7OQscXkZ2/5Wq/R4h39xjZi2gWk+V74ZDzsHBqCE+aYXzClr8CONM5r 1MOvTUSFUhCF7lWdgR5altRc/KnCNrjvIEpZgGIp1l5TMcZZa1SmgMMB1JHcjIvovKdq aBDhOylsaKU9FbRQxg6QGSKUELpTWgOjw7ALGiEQPNS+W0cXQITmkPNgxUOu6wbzaKBz cpXA==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=E/45oSBQhHGzvIBD0fFsRoAZu5iWGPECOZWz87TbH4A=; b=eHK3icDp+sYrJ3hAvf/1UHhs941KdQj4seYjQ4S81f82H+r5ammM+1uMuBgWC2DMh0 4rbvuJ7LLXG6GWcw4idXNcrKEYevfKDqZJ6ZD/q95gwPDPora7BbhwbW+HOeW5KHFm3F T09b/R9C4+r/Rk1glrnEAhIt4dLgYntjHGkFm7mb72GfSeKoses1A+SaRdaf0rEUnJ5G PtKm4NmbDET7qFhCMVBOzZGNPdu1SS77QG02ps+1ZpE/TU33jd+lr73NTDrXcW5lMO4g 3ya0ofsHDURCsYIYBpCaJx2ZUAZmC7c4L2e5CZWVzff6MAFidJ1pKkbaBOXviS0sVMfV Qi7A==
X-Gm-Message-State AKS2vOyswAdyYhYrkTzm1v78bFGwNodfbeByr/+YYWcHxNrj2DHK1IeU 0T702kDpWAX6uSNW5tS4+A==
X-Received by 10.84.216.13 with SMTP id m13mr17798679pli.201.1498741570036; Thu, 29 Jun 2017 06:06:10 -0700 (PDT)
X-Mailer git-send-email 1.9.1
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 27
Organization linux.* mail to news gateway
X-Original-Cc sergio.paracuellos@gmail.com, juliana.orod@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Jaya Durga <rjdurga@gmail.com>, Jaya Durga <jayad@cdac.in>
X-Original-Date Thu, 29 Jun 2017 18:31:00 +0530
X-Original-Message-ID <1498741260-23676-7-git-send-email-rjdurga@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1677744

Show key headers only | View raw


Fix checkpatch.pl issue
WARNING: Use of volatile is usually wrong:
see Documentation/process/volatile-considered-harmful.rst

The variables in the private data that are
marked volatile don't need to be. Remove the volatile.

Signed-off-by: Jaya Durga <jayad@cdac.in>
---
 drivers/staging/wlan-ng/hfa384x.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/wlan-ng/hfa384x.h b/drivers/staging/wlan-ng/hfa384x.h
index 310e2c4..015945f 100644
--- a/drivers/staging/wlan-ng/hfa384x.h
+++ b/drivers/staging/wlan-ng/hfa384x.h
@@ -1175,7 +1175,7 @@ struct hfa384x_usbctlx {
 	enum ctlx_state state;	/* Tracks running state */
 
 	struct completion done;
-	volatile int reapable;	/* Food for the reaper task */
+	int reapable;	/* Food for the reaper task */
 
 	ctlx_cmdcb_t cmdcb;	/* Async command callback */
 	ctlx_usercb_t usercb;	/* Async user callback, */
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile is  usually wrong Jaya Durga <rjdurga@gmail.com> - 2017-06-29 15:10 +0200
  Re: [PATCH v2 6/6] Staging: wlan-ng: hfa384x.h:Fix use of volatile  is  usually wrong Joe Perches <joe@perches.com> - 2017-06-29 15:30 +0200

csiph-web