Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1677723

Re: [PATCH V4 04/12] kernfs: don't set dentry->d_fsdata

From Greg KH <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH V4 04/12] kernfs: don't set dentry->d_fsdata
Date 2017-06-29 15:00 +0200
Message-ID <tXHd7-7Io-7@gated-at.bofh.it> (permalink)
References <tXppV-t5-19@gated-at.bofh.it> <tXppV-t5-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Jun 28, 2017 at 09:29:54AM -0700, Shaohua Li wrote:
> From: Shaohua Li <shli@fb.com>
> 
> When working on adding exportfs operations in kernfs, I found it's hard
> to initialize dentry->d_fsdata in the exportfs operations. Looks there
> is no way to do it without race condition. Look at the kernfs code
> closely, there is no point to set dentry->d_fsdata. inode->i_private
> already points to kernfs_node, and we can get inode from a dentry. So
> this patch just delete the d_fsdata usage.
> 
> Acked-by: Tejun Heo <tj@kernel.org>
> Signed-off-by: Shaohua Li <shli@fb.com>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH V4 04/12] kernfs: don't set dentry->d_fsdata Shaohua Li <shli@kernel.org> - 2017-06-28 20:00 +0200
  Re: [PATCH V4 04/12] kernfs: don't set dentry->d_fsdata Greg KH <gregkh@linuxfoundation.org> - 2017-06-29 15:00 +0200

csiph-web