Re: [PATCH 1/5] clk: mb86s7x: Suppress build

From	Andreas Färber <afaerber@suse.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] clk: mb86s7x: Suppress build
Date	2017-06-29 13:20 +0200
Message-ID	<tXFEm-6Sq-11@gated-at.bofh.it> (permalink)
References	<tWjcR-7Oz-17@gated-at.bofh.it> <tWjcS-7Oz-19@gated-at.bofh.it> <tXpq1-t5-147@gated-at.bofh.it> <tXpq4-t5-205@gated-at.bofh.it> <tXtDc-13b-25@gated-at.bofh.it>
Organization	SUSE Linux GmbH

Show all headers | View raw

Am 29.06.2017 um 00:29 schrieb Stephen Boyd:
> On 06/28, Jassi Brar wrote:
>> On 28 June 2017 at 21:43, Stephen Boyd <sboyd@codeaurora.org> wrote:
>>> On 06/25, Andreas Färber wrote:
>>>> It fails to build once we introduce the ARCH_MB86S7X Kconfig symbol:
>>>>
>>>>   drivers/clk/clk-mb86s7x.c:27:10: fatal error: soc/mb86s7x/scb_mhu.h: No such file or directory
>>>>    #include <soc/mb86s7x/scb_mhu.h>
>>>>             ^~~~~~~~~~~~~~~~~~~~~~~
>>>>   compilation terminated.
[...]
>>>> Comment it out in the Makefile for now.
>>>>
>>>
>>> Why not delete the whole driver instead? It's been two years and
>>> the driver has never compiled.
>>>
>> I won't complain. The interest of moving powers evaporated in the
>> midst of upstreaming. Though some next platform is supposed to reuse
>> the IPs, but I can't say when will that be upstreamed and by whom.

Satoru-san is in CC to comment on that aspect. :)

> Thanks for the info.
> 
> Andreas, can you send a deletion patch instead?

I can.

But obviously the idea is to follow-up on this initial series with an
scb mailbox driver (which is blocking both clk and PM domains drivers)
and to either resolve the compilation failure by adding the expected
symbols or to update the clk driver to build against a new driver.

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Thread

[PATCH 0/5] ARM: Socionext MB86S71 and Fujitsu F-Cue enablement Andreas Färber <afaerber@suse.de> - 2017-06-25 19:10 +0200
  [PATCH 5/5] ARM: dts: mb86s71-f-cue: Add fake UART0 clock Andreas Färber <afaerber@suse.de> - 2017-06-25 19:10 +0200
  [PATCH 1/5] clk: mb86s7x: Suppress build Andreas Färber <afaerber@suse.de> - 2017-06-25 19:10 +0200
    Re: [PATCH 1/5] clk: mb86s7x: Suppress build Stephen Boyd <sboyd@codeaurora.org> - 2017-06-28 20:00 +0200
      Re: [PATCH 1/5] clk: mb86s7x: Suppress build Jassi Brar <jaswinder.singh@linaro.org> - 2017-06-28 20:00 +0200
        Re: [PATCH 1/5] clk: mb86s7x: Suppress build Stephen Boyd <sboyd@codeaurora.org> - 2017-06-29 00:30 +0200
          Re: [PATCH 1/5] clk: mb86s7x: Suppress build Andreas Färber <afaerber@suse.de> - 2017-06-29 13:20 +0200
  [PATCH 4/5] ARM: dts: Add Socionext MB86S71 and Fujitsu F-Cue Andreas Färber <afaerber@suse.de> - 2017-06-25 19:10 +0200
  [PATCH 2/5] ARM: Prepare Socionext MB86S71 Andreas Färber <afaerber@suse.de> - 2017-06-25 19:10 +0200
  [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and Fujitsu F-Cue Andreas Färber <afaerber@suse.de> - 2017-06-25 19:10 +0200
    Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and  Fujitsu F-Cue Rob Herring <robh@kernel.org> - 2017-06-28 20:00 +0200
      Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and  Fujitsu F-Cue Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-29 14:20 +0200
        Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and  Fujitsu F-Cue Andreas Färber <afaerber@suse.de> - 2017-06-29 15:00 +0200
          Re: [PATCH 3/5] dt-bindings: arm: Document Socionext MB86S71 and  Fujitsu F-Cue Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-06-29 19:20 +0200

csiph-web