Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677458
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation |
| Date | 2017-06-29 09:20 +0200 |
| Message-ID | <tXBU7-4BD-9@gated-at.bofh.it> (permalink) |
| References | <tXmV4-8uj-15@gated-at.bofh.it> <tXmV4-8uj-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Josh Poimboeuf <jpoimboe@redhat.com> wrote: > Now that objtool knows the states of all registers on the stack for each > instruction, it's straightforward to generate debuginfo for an unwinder > to use. > > Instead of generating DWARF, generate a new format called undwarf, which > is more suitable for an in-kernel unwinder. See > tools/objtool/Documentation/undwarf.txt for a more detailed description > of this new debuginfo format and why it's preferable to DWARF. > > Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com> > --- > tools/objtool/Build | 3 + > tools/objtool/Documentation/stack-validation.txt | 46 ++--- > tools/objtool/builtin-check.c | 2 +- > tools/objtool/builtin-undwarf.c | 70 ++++++++ > tools/objtool/builtin.h | 1 + > tools/objtool/check.c | 59 ++++++- > tools/objtool/check.h | 15 +- > tools/objtool/elf.c | 212 ++++++++++++++++++++-- > tools/objtool/elf.h | 15 +- > tools/objtool/objtool.c | 3 +- > tools/objtool/undwarf-types.h | 81 +++++++++ Just a very quick stylistic suggestion: please name the header 'undwarf_types.h' (note the underscore versus hyphen), which is the common naming pattern used in the kernel. Thanks, Ingo
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/8] x86: undwarf unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-28 17:20 +0200
[PATCH v2 4/8] objtool: add undwarf debuginfo generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-28 17:20 +0200
Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation Ingo Molnar <mingo@kernel.org> - 2017-06-29 09:20 +0200
Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 15:50 +0200
Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation Ingo Molnar <mingo@kernel.org> - 2017-06-29 09:30 +0200
Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 16:10 +0200
Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation Ingo Molnar <mingo@kernel.org> - 2017-06-29 16:50 +0200
Re: [PATCH v2 4/8] objtool: add undwarf debuginfo generation Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 17:10 +0200
[PATCH v2 7/8] x86/asm: add unwind hint annotations to sync_core() Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-28 17:20 +0200
[PATCH v2 2/8] objtool, x86: add several functions and files to the objtool whitelist Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-28 17:20 +0200
[tip:core/objtool] objtool, x86: Add several functions and files to the objtool whitelist tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-06-30 15:20 +0200
[PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-28 17:20 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 20:00 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Andy Lutomirski <luto@kernel.org> - 2017-06-29 21:00 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 21:10 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Andy Lutomirski <luto@kernel.org> - 2017-06-29 23:20 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 23:50 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Andy Lutomirski <luto@amacapital.net> - 2017-06-30 01:00 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-30 04:20 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Andy Lutomirski <luto@kernel.org> - 2017-06-30 07:10 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Andy Lutomirski <luto@kernel.org> - 2017-06-30 07:50 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-30 15:20 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Andy Lutomirski <luto@kernel.org> - 2017-06-30 17:50 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-30 18:00 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Andy Lutomirski <luto@kernel.org> - 2017-06-30 18:00 +0200
Re: [PATCH v2 6/8] x86/entry: add unwind hint annotations Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-30 18:20 +0200
[PATCH v2 1/8] objtool: move checking code to check.c Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-28 17:20 +0200
Re: [PATCH v2 0/8] x86: undwarf unwinder Ingo Molnar <mingo@kernel.org> - 2017-06-29 10:00 +0200
Re: [PATCH v2 0/8] x86: undwarf unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 16:20 +0200
Re: [PATCH v2 0/8] x86: undwarf unwinder Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-29 21:20 +0200
Re: [PATCH v2 3/8] objtool: stack validation 2.0 Ingo Molnar <mingo@kernel.org> - 2017-06-30 10:40 +0200
Re: [PATCH v2 3/8] objtool: stack validation 2.0 Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-30 15:30 +0200
Re: [PATCH v2 3/8] objtool: stack validation 2.0 Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-30 15:30 +0200
[PATCH] objtool: silence warnings for functions which use iret Josh Poimboeuf <jpoimboe@redhat.com> - 2017-06-30 16:10 +0200
[tip:core/objtool] objtool: Silence warnings for functions which use IRET tip-bot for Josh Poimboeuf <tipbot@zytor.com> - 2017-06-30 20:00 +0200
csiph-web