Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1677411
| From | Sagi Grimberg <sagi@grimberg.me> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() |
| Date | 2017-06-29 07:40 +0200 |
| Message-ID | <tXAlk-3x9-5@gated-at.bofh.it> (permalink) |
| References | (1 earlier) <tViVA-2hN-21@gated-at.bofh.it> <tViVA-2hN-23@gated-at.bofh.it> <tViVA-2hN-17@gated-at.bofh.it> <tWpBE-38C-5@gated-at.bofh.it> <tXpq5-t5-223@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
> Just tested this patch, I wasn't able to reproduce the NULL pointer
> dereference or any other bugs, so this fix seems safe enough to me.
>
> Tested-by: Andrea Righi <righi.andrea@gmail.com>
Can you test just the one liner fix below?
>> @@ -1452,7 +1452,7 @@
>> isert_login_recv_done(struct ib_cq *cq, struct ib_wc *wc)
>> {
>> struct isert_conn *isert_conn = wc->qp->qp_context;
>> - struct ib_device *ib_dev = isert_conn->cm_id->device;
>> + struct ib_device *ib_dev = isert_conn->device->ib_device;
>>
>> if (unlikely(wc->status != IB_WC_SUCCESS)) {
>> isert_print_wc(wc, "login recv");
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32) Andrea Righi <righi.andrea@gmail.com> - 2017-06-23 00:40 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32) "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-06-26 02:00 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Sagi Grimberg <sagi@grimberg.me> - 2017-06-27 09:10 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32) Andrea Righi <righi.andrea@gmail.com> - 2017-06-28 20:00 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Sagi Grimberg <sagi@grimberg.me> - 2017-06-29 07:40 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Andrea Righi <righi.andrea@gmail.com> - 2017-06-29 10:30 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() Sagi Grimberg <sagi@grimberg.me> - 2017-06-29 10:30 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() "Nicholas A. Bellinger" <nab@linux-iscsi.org> - 2017-06-30 08:00 +0200
Re: [PATCH] ib_isert: prevent NULL pointer dereference in isert_login_recv_done() (was: Re: NULL pointer dereference in isert_login_recv_done in 4.9.32) Leon Romanovsky <leon@kernel.org> - 2017-06-26 11:00 +0200
csiph-web