Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1676299

Re: [PATCH v3 0/4] kmod: help make deterministic

Show all headers | View raw

On Tue, Jun 27, 2017 at 05:26:05PM +0200, Jessica Yu wrote:
> +++ Luis R. Rodriguez [27/06/17 00:44 +0200]:
> > Feel free to decouple it, but note that then the commit log must then be
> > changed. My own take is this fix is not so critical as it is a corner case, so
> > I have instead preferred to couple in the test case and respective fix
> > together. I'll leave it up to you how to proceed.
> 
> I'll take 01 and 02 for the next merge window, as they are
> straightforward. 03/04 can stay together, and as I understand it 04
> may need to switch back to using the normal wait_* api.

OK, I'll rework 03-04 with the regular wait and submit aiming towards Andrew's tree.

> I'm not the maintainer for kmod.c, if that's what you mean by
> decoupling.

I was suggesting adding kmod.c to MODULE SUPPORT list as its all module
related, adding my self to the list and I'd just take on helping kmod.c stuff.
My point was that it feels odd to decouple kmod.c from module stuff. But lets
give it a shot with them separated first and see how that goes.

>  But I don't think it has one, which is why I'm suggesting
> adding it to MAINTAINERS, since you've been actively working on it :)
> (looking at git log, it looks like Andrew did most of the sign-off's
> for kmod.c in the past). I think a separate entry in MAINTAINERS is
> good, with the name you suggested.

Sure.

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v3 0/4] kmod: help make deterministic "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-20 23:00 +0200
  Re: [PATCH v3 0/4] kmod: help make deterministic Kees Cook <keescook@chromium.org> - 2017-06-21 02:30 +0200
    Re: [PATCH v3 0/4] kmod: help make deterministic Jessica Yu <jeyu@redhat.com> - 2017-06-26 23:40 +0200
      Re: [PATCH v3 0/4] kmod: help make deterministic "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-27 00:50 +0200
        Re: [PATCH v3 0/4] kmod: help make deterministic "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-27 02:30 +0200
          Re: [PATCH v3 0/4] kmod: help make deterministic Petr Mladek <pmladek@suse.com> - 2017-06-27 10:20 +0200
            Re: [PATCH v3 0/4] kmod: help make deterministic Jessica Yu <jeyu@redhat.com> - 2017-06-27 12:10 +0200
        Re: [PATCH v3 0/4] kmod: help make deterministic Jessica Yu <jeyu@redhat.com> - 2017-06-27 17:30 +0200
          Re: [PATCH v3 0/4] kmod: help make deterministic "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-06-28 02:50 +0200

csiph-web