Re: [PATCH] PCI: mediatek: change to use the new host bridge interface

Path	csiph.com!news.mixmin.net!news.unit0.net!newsfeed.CARNet.hr!news.spin.it!bofh.it!news.nic.it!robomod
From	Ryder Lee <ryder.lee@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: mediatek: change to use the new host bridge interface
Date	Wed, 28 Jun 2017 03:30:01 +0200
Message-ID	<tX9XP-bC-9@gated-at.bofh.it> (permalink)
References	<tWUYN-6V2-13@gated-at.bofh.it> <tWUYN-6V2-11@gated-at.bofh.it> <tX7jl-6UY-31@gated-at.bofh.it> <tX85H-7qz-3@gated-at.bofh.it>
X-Original-To	Bjorn Helgaas <helgaas@kernel.org>
Content-Type	text/plain; charset="UTF-8"
X-Mailer	Evolution 3.2.3-0ubuntu6
Content-Transfer-Encoding	7bit
MIME-Version	1.0
X-Mtk	N
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	36
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, Stephen Rothwell <sfr@canb.auug.org.au>, Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>
X-Original-Date	Wed, 28 Jun 2017 09:21:26 +0800
X-Original-Message-ID	<1498612886.20242.12.camel@mtkswgap22>
X-Original-References	<1498555451-55073-1-git-send-email-ryder.lee@mediatek.com> <1498555451-55073-2-git-send-email-ryder.lee@mediatek.com> <20170627223039.GE17844@bhelgaas-glaptop.roam.corp.google.com> <20170627232057.GK17844@bhelgaas-glaptop.roam.corp.google.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1676308

Show key headers only | View raw

On Tue, 2017-06-27 at 18:20 -0500, Bjorn Helgaas wrote:
> On Tue, Jun 27, 2017 at 05:30:40PM -0500, Bjorn Helgaas wrote:
> > On Tue, Jun 27, 2017 at 05:24:11PM +0800, Ryder Lee wrote:
> > > With the introduction of pci_scan_root_bus_bridge() there is no need to
> > > export pci_register_host_bridge() to other kernel subsystems other than the
> > > PCI compilation unit that needs it.
> > > 
> > > Make pci_register_host_bridge() static to its compilation unit and convert
> > > the existing drivers usage over to pci_scan_root_bus_bridge().
> > > 
> > > Also, when probing the PCI host controller driver, if an error occurs, the probe
> > > function code does not free memory allocated for the struct pci_host_bridge
> > > resulting in memory leakage.
> > > 
> > > This patch fixes them by using the methods that introduces by Lorenzo.
> > > 
> > > Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
> > 
> > I rebased my pci/host-mediatek branch on top of pci/enumeration (which
> > contains the series from Lorenzo), and folded this into the initial
> > MediaTek driver commit.
> > 
> > This branch:
> > 
> > https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?h=pci/host-mediatek&id=b6ca15d18881b784dc9efc5d81989be26ecd9fc8
> > 
> > should have all the MediaTek bits I know about.  Can you double-check
> > it, please?
> 
> Sorry, that's wrong; I see your controller powerup stuff in patchwork, and
> that's *not* included yet.

Yes, that should be folded into the initial commit if possible.
Thanks for your help!

Ryder

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: mediatek: change to use the new host bridge interface Ryder Lee <ryder.lee@mediatek.com> - 2017-06-27 11:30 +0200
  Re: [PATCH] PCI: mediatek: change to use the new host bridge  interface Bjorn Helgaas <helgaas@kernel.org> - 2017-06-28 00:40 +0200
    Re: [PATCH] PCI: mediatek: change to use the new host bridge  interface Bjorn Helgaas <helgaas@kernel.org> - 2017-06-28 01:30 +0200
      Re: [PATCH] PCI: mediatek: change to use the new host bridge  interface Ryder Lee <ryder.lee@mediatek.com> - 2017-06-28 03:30 +0200

csiph-web