Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1676236

Re: [BUG] ftrace: WARNING: suspicious RCU usage

From Steven Rostedt <rostedt@goodmis.org>
Newsgroups linux.kernel
Subject Re: [BUG] ftrace: WARNING: suspicious RCU usage
Date 2017-06-28 01:00 +0200
Message-ID <tX7CF-71T-1@gated-at.bofh.it> (permalink)
References <tWXjY-8qo-29@gated-at.bofh.it> <tWYJ4-14q-9@gated-at.bofh.it> <tWZc5-1gg-1@gated-at.bofh.it> <tX7CF-71T-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, 28 Jun 2017 07:52:22 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:

> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index e354e47..442b409 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -973,8 +973,10 @@ static void rcu_eqs_exit(bool user)
>  	if (oldval & DYNTICK_TASK_NEST_MASK) {
>  		rdtp->dynticks_nesting += DYNTICK_TASK_NEST_VALUE;
>  	} else {
> +		__this_cpu_inc(disable_rcu_irq_enter);
>  		rdtp->dynticks_nesting = DYNTICK_TASK_EXIT_IDLE;
>  		rcu_eqs_exit_common(oldval, user);
> +		__this_cpu_dec(disable_rcu_irq_enter);
>  	}
>  }
>  

Looks like a good fix to me. Paul want to take this one?

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [BUG] ftrace: WARNING: suspicious RCU usage Steven Rostedt <rostedt@goodmis.org> - 2017-06-27 15:30 +0200
  Re: [BUG] ftrace: WARNING: suspicious RCU usage Masami Hiramatsu <mhiramat@kernel.org> - 2017-06-27 16:00 +0200
    Re: [BUG] ftrace: WARNING: suspicious RCU usage Steven Rostedt <rostedt@goodmis.org> - 2017-06-28 01:00 +0200
      Re: [BUG] ftrace: WARNING: suspicious RCU usage "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-06-28 02:50 +0200
    Re: [BUG] ftrace: WARNING: suspicious RCU usage Masami Hiramatsu <mhiramat@kernel.org> - 2017-06-28 01:00 +0200

csiph-web