Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions

From	Wolfram Sang <wsa@the-dreams.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions
Date	2017-06-27 23:40 +0200
Message-ID	<tX6nf-6jD-11@gated-at.bofh.it> (permalink)
References	<tV7nr-3hH-15@gated-at.bofh.it> <tV7nr-3hH-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Thu, Jun 22, 2017 at 11:17:32AM +0100, Luis Oliveira wrote:
> - Changes in Kconfig to enable I2C_DESIGNWARE_SLAVE support
> - Slave functions added to core library file
> - Slave abort sources added to common source file
> - New driver: i2c-designware-slave added
> - Changes in the Makefile to compile the I2C_DESIGNWARE_SLAVE module
>   when supported by the architecture.
> 
> All the SLAVE flow is added but it is not enabled via platform
> driver.
> 
> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>

I fixed this checkpatch warning for you:

WARNING: quoted string split across lines
#391: FILE: drivers/i2c/busses/i2c-designware-slave.c:281:
+		"%#x STAUTS SLAVE_ACTTVITY=%#x : RAW_INTR_STAT=%#x"
+		" : INTR_STAT=%#x\n",

Nice, you fooled two code checkers by having code in comments :) No
need to fix, of course:

    SMATCH
drivers/i2c/busses/i2c-designware-slave.c:318 i2c_dw_irq_handler_slave warn: unused return: stat = i2c_dw_read_clear_intrbits_slave()
drivers/i2c/busses/i2c-designware-slave.c:329 i2c_dw_irq_handler_slave warn: unused return: stat = i2c_dw_read_clear_intrbits_slave()
    CPPCHECK
drivers/i2c/busses/i2c-designware-slave.c:329: style: Variable 'stat' is assigned a value that is never used.

Build warning:

  CC      drivers/i2c/busses/i2c-designware-slave.o
drivers/i2c/busses/i2c-designware-slave.c:173:5: warning: no previous prototype for ‘i2c_dw_reg_slave’ [-Wmissing-prototypes]
 int i2c_dw_reg_slave(struct i2c_client *slave)

I declared the function static to fix it.

Applied to for-next, thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v12 1/2] i2c: designware: add SLAVE mode functions Luis Oliveira <Luis.Oliveira@synopsys.com> - 2017-06-22 12:20 +0200
  Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2017-06-27 16:30 +0200
  Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2017-06-27 16:30 +0200
  Re: [PATCH v12 1/2] i2c: designware: add SLAVE mode functions Wolfram Sang <wsa@the-dreams.de> - 2017-06-27 23:40 +0200

csiph-web