Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1676167
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: mmotm 2017-06-23-15-03 uploaded |
| Date | 2017-06-27 22:50 +0200 |
| Message-ID | <tX5AS-5JN-15@gated-at.bofh.it> (permalink) |
| References | <tVEW5-7RD-3@gated-at.bofh.it> <tWStX-57j-7@gated-at.bofh.it> <tWSNj-5uf-3@gated-at.bofh.it> <tWSNj-5uf-9@gated-at.bofh.it> <tWTgm-5HC-29@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, 27 Jun 2017 09:38:09 +0200 Rasmus Villemoes <linux@rasmusvillemoes.dk> wrote:
> >>
> >> However, the patch in mmotm seems to be missing this crucial hunk that
> >> Rasmus had in the patch he sent [1]:
> >>
> >> -__rmqueue_fallback(struct zone *zone, unsigned int order, int
> >> start_migratetype)
> >> +__rmqueue_fallback(struct zone *zone, int order, int start_migratetype)
> >>
> >> which makes this a signed vs signed comparison.
> >>
> >> What happened to it? Andrew?
>
> This is really odd. Checking, I see that it was also absent from the
> 'this patch has been added to -mm' mail, but I admit I don't proofread
> those to see they match what I sent. Oh well. Let me know if I need to
> do anything.
>
oops, that was me manually fixing rejects - I missed a bit.
--- a/mm/page_alloc.c~mm-page_allocc-eliminate-unsigned-confusion-in-__rmqueue_fallback-fix
+++ a/mm/page_alloc.c
@@ -2212,7 +2212,7 @@ static bool unreserve_highatomic_pageblo
* condition simpler.
*/
static inline bool
-__rmqueue_fallback(struct zone *zone, unsigned int order, int start_migratetype)
+__rmqueue_fallback(struct zone *zone, int order, int start_migratetype)
{
struct free_area *area;
int current_order;
_
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
mmotm 2017-06-23-15-03 uploaded akpm@linux-foundation.org - 2017-06-24 00:10 +0200
Re: mmotm 2017-06-23-15-03 uploaded huang ying <huang.ying.caritas@gmail.com> - 2017-06-27 08:50 +0200
Re: mmotm 2017-06-23-15-03 uploaded Vlastimil Babka <vbabka@suse.cz> - 2017-06-27 09:10 +0200
Re: mmotm 2017-06-23-15-03 uploaded Vlastimil Babka <vbabka@suse.cz> - 2017-06-27 09:10 +0200
Re: mmotm 2017-06-23-15-03 uploaded Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2017-06-27 09:40 +0200
Re: mmotm 2017-06-23-15-03 uploaded Andrew Morton <akpm@linux-foundation.org> - 2017-06-27 22:50 +0200
Re: mmotm 2017-06-23-15-03 uploaded Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-28 00:00 +0200
Re: mmotm 2017-06-23-15-03 uploaded Stephen Rothwell <sfr@canb.auug.org.au> - 2017-06-28 00:10 +0200
csiph-web