Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1676055
| Path | csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod |
|---|---|
| From | Borislav Petkov <bp@alien8.de> |
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2 1/3] x86/numa_emulation: fix potential memory leak |
| Date | Tue, 27 Jun 2017 20:20:01 +0200 |
| Message-ID | <tX3fH-4fe-5@gated-at.bofh.it> (permalink) |
| References | <tCFJ0-77a-21@gated-at.bofh.it> <tCFIZ-77a-19@gated-at.bofh.it> <tWEhk-47v-27@gated-at.bofh.it> <tWLst-p6-3@gated-at.bofh.it> |
| MIME-Version | 1.0 |
| Content-Type | text/plain; charset=utf-8 |
| Content-Disposition | inline |
| User-Agent | NeoMutt/20170113 (1.7.2) |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 28 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | kirill@shutemov.name, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, tj@kernel.org, rientjes@google.com, linux-kernel@vger.kernel.org |
| X-Original-Date | Tue, 27 Jun 2017 20:10:49 +0200 |
| X-Original-Message-ID | <20170627181049.phlrtpkf3mqi4kt6@pd.tnic> |
| X-Original-References | <20170502130453.5933-1-richard.weiyang@gmail.com> <20170502130453.5933-2-richard.weiyang@gmail.com> <20170626153149.b2x5pcipzuzaguuw@pd.tnic> <20170626231127.GA53180@WeideMacBook-Pro.local> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1676055 |
Show key headers only | View raw
On Tue, Jun 27, 2017 at 07:11:27AM +0800, Wei Yang wrote:
> It means numa emulation is not properly configured.
Or what the error message says: it cannot determine the default physical
node because NUMA emulation is not properly configured. What I'm trying
to say, is, explain the *why* in the commit message, not the *what*. The
*what* one can see in the code.
> Well, to this particular piece, have a for loop within a function doesn't look
> like a big deal to me. So you prefer to take every for loop in this function
> out?
As I said, I'd prefer you take this loop out and turn it into a separate
function in one go, along with fixing the potential memory leak.
> Last but not the least, these are two issues:
>
> The problem this patch wants to address is the memory leak, while the concern
> here you mentioned is the coding style.
Let's not get too pedantic here: if you carve it out in a separate
function, it is still clear what the patch is doing.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V2 1/3] x86/numa_emulation: fix potential memory leak Borislav Petkov <bp@alien8.de> - 2017-06-26 17:40 +0200
Re: [PATCH V2 1/3] x86/numa_emulation: fix potential memory leak Wei Yang <richard.weiyang@gmail.com> - 2017-06-27 01:20 +0200
Re: [PATCH V2 1/3] x86/numa_emulation: fix potential memory leak Borislav Petkov <bp@alien8.de> - 2017-06-27 20:20 +0200
Re: [PATCH V2 1/3] x86/numa_emulation: fix potential memory leak Wei Yang <richard.weiyang@gmail.com> - 2017-06-28 01:40 +0200
csiph-web