Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe

From	Benson Leung <bleung@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive at probe
Date	2017-06-27 17:40 +0200
Message-ID	<tX0KS-2rx-21@gated-at.bofh.it> (permalink)
References	<taRqx-62G-3@gated-at.bofh.it> <taRqz-62G-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Thierry,

On Tue, Feb 14, 2017 at 08:58:01PM +0100, Thierry Escande wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
> 
> When the EC is not responsive at probe, we try to get basic information
> (protocol to use) later on through cros_xfer_cmd() call.
> This patch makes sure there is no deadlock when re-probing the EC by
> replacing call to cros_xfer_cmd() with send_command() in the function
> cros_ec_get_host_command_version_mask(). Also, this patch adds the
> function header indicating it must be called protected.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Thierry Escande <thierry.escande@collabora.com>

Applied. Thanks again!

-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2 2/3] cros_ec: Fix deadlock when EC is not responsive  at probe Benson Leung <bleung@google.com> - 2017-06-27 17:40 +0200

csiph-web