Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1675902

Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T

Show all headers | View raw

2017-06-27 1:15 GMT+08:00 Maxime Ripard <maxime.ripard@free-electrons.com>:
> Hi,
>
> On Sat, Jun 24, 2017 at 10:45:14AM +0800, Ziping Chen wrote:
>> From: Ziping Chen <techping.chan@gmail.com>
>>
>> Allwinner A83T SoC has a low res adc like the one
>> in Allwinner A10 SoC.
>>
>> Add binding for it.
>>
>> Signed-off-by: Ziping Chen <techping.chan@gmail.com>
>> Acked-by: Rob Herring <robh@kernel.org>
>> ---
>>  Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
>> index 4357e498ef04..525d85e3043f 100644
>> --- a/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
>> +++ b/Documentation/devicetree/bindings/input/sun4i-lradc-keys.txt
>> @@ -2,12 +2,14 @@ Allwinner sun4i low res adc attached tablet keys
>>  ------------------------------------------------
>>
>>  Required properties:
>> - - compatible: "allwinner,sun4i-a10-lradc-keys"
>> + - compatible: should be one of the following string:
>> +             "allwinner,sun4i-a10-lradc-keys"
>> +             "allwinner,sun8i-a83t-r-lradc-keys"
>
> This doesn't really have anything related to keys, and can be used
> purely as an ADC.
>
> I know this is the compatible that was used for the A10, but I'd
> rather drop the keys for the the new compatible.
>

Hi,
LRADC is named KEYADC in some other SoCs' User Manual(such as R40 User
Manual V1.0), thus LRADC is related to keys.

Without keys there is another driver named sun4i-gpadc-iio which is
located at driver/iio/adc/sun4i-gpadc-iio.c

Is my understanding right?

> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Ziping Chen <techping.chan@gmail.com> - 2017-06-24 04:50 +0200
  Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-26 19:20 +0200
    Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC  support for A83T icenowy@aosc.io - 2017-06-27 17:30 +0200
      Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC  support for A83T Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-27 19:40 +0200
        Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC  support for A83T Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2017-06-27 20:20 +0200
        Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC  support for A83T Ziping Chen <techping.chan@gmail.com> - 2017-06-29 06:50 +0200
          Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC  support for A83T Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-29 10:00 +0200
            Re: [linux-sunxi] Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC  support for A83T Ziping Chen <techping.chan@gmail.com> - 2017-06-29 14:20 +0200
    Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Ziping Chen <techping.chan@gmail.com> - 2017-06-27 17:30 +0200
      Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-27 19:40 +0200
        Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Ziping Chen <techping.chan@gmail.com> - 2017-06-29 06:40 +0200
          Re: [PATCH v3 2/3] dt-bindings: input: Add R_LRADC support for A83T Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-06-29 10:00 +0200

csiph-web