Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1674443

Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt

From David Gstir <david@sigma-star.at>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt
Date 2017-06-26 07:50 +0200
Message-ID <tWv4m-6Jc-7@gated-at.bofh.it> (permalink)
References <tNTSh-11x-3@gated-at.bofh.it> <tNTSh-11x-1@gated-at.bofh.it> <tU2ga-1qR-3@gated-at.bofh.it> <tUh5w-2E2-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Herbert,

> On 20 Jun 2017, at 03:28, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> 
> On Mon, Jun 19, 2017 at 10:31:27AM +0000, Horia Geantă wrote:
>> 
>> IIUC, IV update is required only in case of CBC.
>> Since this callback is used also for CTR, we should avoid the copy:
>> if ((ctx->cdata.algtype & OP_ALG_AAI_MASK) == OP_ALG_AAI_CBC) ...
> 
> No it is needed for CTR too.

So, am I correct in assuming that it is required for all modes including AEAD modes like GCM?
In that case I'll include a fix for the CAAM GCM mode too.

Thanks,
David

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt Herbert Xu <herbert@gondor.apana.org.au> - 2017-06-20 04:30 +0200
  Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt David Gstir <david@sigma-star.at> - 2017-06-26 07:50 +0200
    Re: [RFC PATCH 1/2] crypto: caam - properly set IV after {en,de}crypt Herbert Xu <herbert@gondor.apana.org.au> - 2017-06-26 08:50 +0200

csiph-web