Re: [PATCH] net/icmp: restore source address if packet is NATed

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net/icmp: restore source address if packet is NATed
Date	2017-06-26 03:50 +0200
Message-ID	<tWrk5-4f5-9@gated-at.bofh.it> (permalink)
References	<tVIQ1-1SY-7@gated-at.bofh.it> <tWhXr-6Sh-7@gated-at.bofh.it> <tWoFA-2yd-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: "Jason A. Donenfeld" <Jason@zx2c4.com>
Date: Mon, 26 Jun 2017 00:52:09 +0200

> On Sun, Jun 25, 2017 at 5:49 PM, David Miller <davem@davemloft.net> wrote:
>> You definitely can't just rewrite header fields here either.  The
>> SKB could be shared, for example.
> 
> I was afraid of that. It's easy to rework this particular patch,
> though, if you're still interested in the crufty bolt on approach...
> But I think I should investigate the netfilter-only approach instead,
> as you suggested.

I highly encourage you to continue pursuing the netfilter based
approach, and to also discuss it on netfilter-devel which will
hit more capable minds than just here on netdev.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net/icmp: restore source address if packet is NATed "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-24 04:20 +0200
  Re: [PATCH] net/icmp: restore source address if packet is NATed David Miller <davem@davemloft.net> - 2017-06-25 17:50 +0200
    Re: [PATCH] net/icmp: restore source address if packet is NATed "Jason A. Donenfeld" <Jason@zx2c4.com> - 2017-06-26 01:00 +0200
      Re: [PATCH] net/icmp: restore source address if packet is NATed David Miller <davem@davemloft.net> - 2017-06-26 03:50 +0200

csiph-web