Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE

From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE
Date	2017-06-25 15:00 +0200
Message-ID	<tWfiW-5cl-13@gated-at.bofh.it> (permalink)
References	<tWePU-52w-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Jun 25, 2017 at 08:22:06AM -0400, Tommy Nguyen wrote:
> Running coccicheck indicates that DEFINE_DEBUGFS_ATTRIBUTE
> and debugfs_create_file_unsafe should be used instead.

Why use the _unsafe version?  Are you sure it will work properly?  What
benifit does it offer?

> 
> Signed-off-by: Tommy Nguyen <remyabel@gmail.com>
> ---
>  drivers/staging/android/ion/ion.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 03d3a4f..8f96b38 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -544,8 +544,8 @@ static int debug_shrink_get(void *data, u64 *val)
>  	return 0;
>  }
>  
> -DEFINE_SIMPLE_ATTRIBUTE(debug_shrink_fops, debug_shrink_get,
> -			debug_shrink_set, "%llu\n");
> +DEFINE_DEBUGFS_ATTRIBUTE(debug_shrink_fops, debug_shrink_get,
> +			 debug_shrink_set, "%llu\n");

Are you sure this works?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE Tommy Nguyen <remyabel@gmail.com> - 2017-06-25 14:30 +0200
  Re: [PATCH] staging: android: ion: Use DEFINE_DEBUGFS_ATTRIBUTE Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2017-06-25 15:00 +0200

csiph-web