Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1675726

[PATCH net-next 3/3] net: ethernet: ti: netcp_ethss: use cpts to check if packet needs timestamping

From Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
Newsgroups linux.kernel
Subject [PATCH net-next 3/3] net: ethernet: ti: netcp_ethss: use cpts to check if packet needs timestamping
Date 2017-06-27 16:00 +0200
Message-ID <tWZc7-1gg-39@gated-at.bofh.it> (permalink)
References <tWZc6-1gg-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


There is cpts function to check if packet can be timstamped with cpts.
Seems that ptp_classify_raw cover all cases listed with "case".

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>
---
 drivers/net/ethernet/ti/netcp_ethss.c | 18 +-----------------
 1 file changed, 1 insertion(+), 17 deletions(-)

diff --git a/drivers/net/ethernet/ti/netcp_ethss.c b/drivers/net/ethernet/ti/netcp_ethss.c
index 0847a8f..28cb38a 100644
--- a/drivers/net/ethernet/ti/netcp_ethss.c
+++ b/drivers/net/ethernet/ti/netcp_ethss.c
@@ -2503,24 +2503,8 @@ static bool gbe_need_txtstamp(struct gbe_intf *gbe_intf,
 			      const struct netcp_packet *p_info)
 {
 	struct sk_buff *skb = p_info->skb;
-	unsigned int class = ptp_classify_raw(skb);
 
-	if (class == PTP_CLASS_NONE)
-		return false;
-
-	switch (class) {
-	case PTP_CLASS_V1_IPV4:
-	case PTP_CLASS_V1_IPV6:
-	case PTP_CLASS_V2_IPV4:
-	case PTP_CLASS_V2_IPV6:
-	case PTP_CLASS_V2_L2:
-	case (PTP_CLASS_V2_VLAN | PTP_CLASS_L2):
-	case (PTP_CLASS_V2_VLAN | PTP_CLASS_IPV4):
-	case (PTP_CLASS_V2_VLAN | PTP_CLASS_IPV6):
-		return true;
-	}
-
-	return false;
+	return cpts_can_timestamp(gbe_intf->gbe_dev->cpts, skb);
 }
 
 static int gbe_txtstamp_mark_pkt(struct gbe_intf *gbe_intf,
-- 
2.7.4

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH net-next 0/3] fix sw timestamping for non PTP packets Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-06-27 16:00 +0200
  [PATCH net-next 3/3] net: ethernet: ti: netcp_ethss: use cpts to check if packet needs timestamping Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-06-27 16:00 +0200
  [PATCH net-next 1/3] net: ethernet: ti: cpsw: move skb timestamp to packet_submit Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> - 2017-06-27 16:10 +0200
  Re: [PATCH net-next 0/3] fix sw timestamping for non PTP packets Grygorii Strashko <grygorii.strashko@ti.com> - 2017-06-28 23:30 +0200
  Re: [PATCH net-next 0/3] fix sw timestamping for non PTP packets David Miller <davem@davemloft.net> - 2017-06-29 18:30 +0200

csiph-web