Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675633
| From | Matthias Schiffer <mschiffer@universe-factory.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH net-next] vxlan: fix incorrect nlattr access in MTU check |
| Date | 2017-06-27 14:50 +0200 |
| Message-ID | <tWY6m-xc-21@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The access to the wrong variable could lead to a NULL dereference and
possibly other invalid memory reads in vxlan newlink/changelink requests
with a IFLA_MTU attribute.
Fixes: a985343ba906 "vxlan: refactor verification and application of configuration"
Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
---
drivers/net/vxlan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
index 0dafd8e6c665..fd0ff97e3d81 100644
--- a/drivers/net/vxlan.c
+++ b/drivers/net/vxlan.c
@@ -2727,7 +2727,7 @@ static int vxlan_validate(struct nlattr *tb[], struct nlattr *data[],
}
if (tb[IFLA_MTU]) {
- u32 mtu = nla_get_u32(data[IFLA_MTU]);
+ u32 mtu = nla_get_u32(tb[IFLA_MTU]);
if (mtu < ETH_MIN_MTU || mtu > ETH_MAX_MTU)
return -EINVAL;
--
2.13.2
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH net-next] vxlan: fix incorrect nlattr access in MTU check Matthias Schiffer <mschiffer@universe-factory.net> - 2017-06-27 14:50 +0200 Re: [PATCH net-next] vxlan: fix incorrect nlattr access in MTU check David Miller <davem@davemloft.net> - 2017-06-27 20:50 +0200
csiph-web