Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1675565

[PATCH 3.16 4/7] regulator: core: Fix regualtor_ena_gpio_free not to access pin after freeing

From Ben Hutchings <ben@decadent.org.uk>
Newsgroups linux.kernel
Subject [PATCH 3.16 4/7] regulator: core: Fix regualtor_ena_gpio_free not to access pin after freeing
Date 2017-06-27 13:20 +0200
Message-ID <tWWHg-8aL-27@gated-at.bofh.it> (permalink)
References <tWWHf-8aL-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


3.16.45-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Seung-Woo Kim <sw0312.kim@samsung.com>

commit 60a2362f769cf549dc466134efe71c8bf9fbaaba upstream.

After freeing pin from regulator_ena_gpio_free, loop can access
the pin. So this patch fixes not to access pin after freeing.

Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 drivers/regulator/core.c | 2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1709,6 +1709,8 @@ static void regulator_ena_gpio_free(stru
 				gpio_free(pin->gpio);
 				list_del(&pin->list);
 				kfree(pin);
+				rdev->ena_pin = NULL;
+				return;
 			} else {
 				pin->request_count--;
 			}

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH 3.16 4/7] regulator: core: Fix regualtor_ena_gpio_free not  to access pin after freeing Ben Hutchings <ben@decadent.org.uk> - 2017-06-27 13:20 +0200

csiph-web