Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1675320
| From | Matthew Wilcox <willy@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 16/51] block: bounce: avoid direct access to bvec table |
| Date | 2017-06-27 08:20 +0200 |
| Message-ID | <tWS0W-4W7-19@gated-at.bofh.it> (permalink) |
| References | <tWB9L-2fr-3@gated-at.bofh.it> <tWB9N-2fr-51@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jun 26, 2017 at 08:09:59PM +0800, Ming Lei wrote:
> bio_for_each_segment_all(bvec, bio, i) {
> - org_vec = bio_orig->bi_io_vec + i + start;
> -
> - if (bvec->bv_page == org_vec->bv_page)
> - continue;
> + orig_vec = bio_iter_iovec(bio_orig, orig_iter);
> + if (bvec->bv_page == orig_vec.bv_page)
> + goto next;
>
> dec_zone_page_state(bvec->bv_page, NR_BOUNCE);
> mempool_free(bvec->bv_page, pool);
> + next:
> + bio_advance_iter(bio_orig, &orig_iter, orig_vec.bv_len);
> }
>
I think this might be written more clearly as:
bio_for_each_segment_all(bvec, bio, i) {
orig_vec = bio_iter_iovec(bio_orig, orig_iter);
if (bvec->bv_page != orig_vec.bv_page) {
dec_zone_page_state(bvec->bv_page, NR_BOUNCE);
mempool_free(bvec->bv_page, pool);
}
bio_advance_iter(bio_orig, &orig_iter, orig_vec.bv_len);
}
What do you think?
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 16/51] block: bounce: avoid direct access to bvec table Ming Lei <ming.lei@redhat.com> - 2017-06-26 14:20 +0200
Re: [PATCH v2 16/51] block: bounce: avoid direct access to bvec table Matthew Wilcox <willy@infradead.org> - 2017-06-27 08:20 +0200
Re: [PATCH v2 16/51] block: bounce: avoid direct access to bvec table Ming Lei <ming.lei@redhat.com> - 2017-06-27 09:40 +0200
csiph-web