Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1675306

Re: [PATCH] media: omap3isp: handle NULL return of omap3isp_video_format_info() in ccdc_is_shiftable().

Show all headers | View raw

Hi,

> Am 26.06.2017 um 22:12 schrieb Sakari Ailus <sakari.ailus@iki.fi>:
> 
> Hi Nikolaus,
> 
> On Mon, Jun 26, 2017 at 07:54:19PM +0200, H. Nikolaus Schaller wrote:
>> If a camera module driver specifies a format that is not
>> supported by omap3isp this ends in a NULL pointer
>> dereference instead of a simple fail.
> 
> Has this happened in practice?

Yes. I wouldn't have noticed it otherwise.

It happens with a new ov965x driver just submitted for review.
It seems to provide some format that the omap3isp does not understand.

I can send you a console stack log if needed.

> If it does, it is probably a driver bug ---
> the formats on its pads should be recognised by the driver.

> 
> WARN_ON() around the condition would be good to avoid silently ignoring such
> issues.
> 
> I wonder what Laurent thinks.
> 
>> 
>> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
>> ---
>> drivers/media/platform/omap3isp/ispccdc.c | 3 +++
>> 1 file changed, 3 insertions(+)
>> 
>> diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
>> index 2fb755f20a6b..dcf16ee7c612 100644
>> --- a/drivers/media/platform/omap3isp/ispccdc.c
>> +++ b/drivers/media/platform/omap3isp/ispccdc.c
>> @@ -2397,6 +2397,9 @@ static bool ccdc_is_shiftable(u32 in, u32 out, unsigned int additional_shift)
>> 	in_info = omap3isp_video_format_info(in);
>> 	out_info = omap3isp_video_format_info(out);
>> 
>> +	if (!in_info || !out_info)
>> +		return false;
>> +
>> 	if ((in_info->flavor == 0) || (out_info->flavor == 0))
>> 		return false;
>> 
> 
> -- 
> Regards,
> 
> Sakari Ailus
> e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

BR and thanks,
Nikolaus

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] media: omap3isp: handle NULL return of omap3isp_video_format_info() in ccdc_is_shiftable(). "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-06-26 20:00 +0200
  Re: [PATCH] media: omap3isp: handle NULL return of  omap3isp_video_format_info() in ccdc_is_shiftable(). Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-26 22:20 +0200
    Re: [PATCH] media: omap3isp: handle NULL return of omap3isp_video_format_info() in ccdc_is_shiftable(). "H. Nikolaus Schaller" <hns@goldelico.com> - 2017-06-27 07:50 +0200
      Re: [PATCH] media: omap3isp: handle NULL return of  omap3isp_video_format_info() in ccdc_is_shiftable(). Sakari Ailus <sakari.ailus@iki.fi> - 2017-06-27 08:00 +0200

csiph-web